Skip to content

Conversation

cotti
Copy link
Contributor

@cotti cotti commented Mar 29, 2025

Handles #865

As I was working on it, I found a couple of mapped pages set incorrectly, and sent PRs on the way of the repositories. Running locally works (once manually fixed for now, that is)

As the mapping file is acquired by docs-assembler, checking out the results locally requires builder's serve-static.

Prerequisites:

@cotti cotti requested a review from a team as a code owner March 29, 2025 05:05
@cotti cotti changed the title [WIPFeature/frontmatter previous version disclaimer [WIP] Previous version admonitions using front matter information Mar 29, 2025
@cotti cotti changed the title [WIP] Previous version admonitions using front matter information [WIP] Previous version admonitions on document pages with mapped entries in front matter Mar 29, 2025
@cotti cotti added the feature label Mar 29, 2025
@cotti cotti self-assigned this Mar 29, 2025
@cotti cotti linked an issue Mar 29, 2025 that may be closed by this pull request
cotti added 2 commits March 29, 2025 19:37
…sion_disclaimer' into feature/frontmatter_previous_version_disclaimer
@cotti cotti marked this pull request as draft March 31, 2025 11:34
@cotti cotti marked this pull request as ready for review March 31, 2025 18:08
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few nitpicks about how HistoryMapper flows through the object graph.

…ted into HtmlWriter instead of a BuildContext property, and adjust legacyUrl nomenclature
@cotti cotti requested a review from Mpdreamz March 31, 2025 21:07
@cotti cotti changed the title [WIP] Previous version admonitions on document pages with mapped entries in front matter Previous version links on document pages with mapped entries in front matter Mar 31, 2025
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cotti cotti merged commit 6e82228 into main Apr 1, 2025
14 checks passed
@cotti cotti deleted the feature/frontmatter_previous_version_disclaimer branch April 1, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use frontmatter to link users to previous versions of the documentation

3 participants