-
Notifications
You must be signed in to change notification settings - Fork 160
Note in ECK autoscaling docs how cpu/ram is scaled. #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6a5ca27
Note in ECK autoscaling docs how cpu/ram is scaled.
naemono 7b6bb38
Further clarify the autoscaling settings.
naemono d06a3cc
Note exclusion of frozen tiers when discussing data tiers.
naemono e48cace
Merge branch 'main' into eck-update-autoscaling-docs
naemono 3a2be27
Move to a table to display data more clearly.
naemono 305914e
Add back sentence.
naemono f8a82dc
capitalize CPU in table
naemono 82cfd71
Merge branch 'main' into eck-update-autoscaling-docs
naemono File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should not consider the resource types returned for each tiers as an implementation detail. It feels like we are duplicating the Elasticsearch documentation which already explains what type of resources are estimated: https://www.elastic.co/guide/en/elasticsearch/reference/current/autoscaling-deciders.html
Instead we could explain how missing resources are calculated by the operator:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do what @barkbay suggests. But I also think we should call out in very simple language what is actually supported or not supported today. I know this would be duplicating some of the content from the Elasticsearch docs on deciders but it can be a bit confusing to read the decider docs. Do all of them apply, which ones do not apply?
I am struggeling to parse this wording. What are we trying to say here? Why can ECK scale memory when you specify what? What is
ElasticsearchAutoscaler.cpu
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a typo. Intended to be
ElasticsearchAutoscaler.spec
. ECK can scale memory in frozen tiers according to what's returned by the ES deciders if specified, otherwise it will scale it in relation to storage.This isn't the most straight-forward thing to understand from a customer standpoint, as each tier has it's own set of supported options. Would a table showing the available options for each tier be a more clear that the words we're suggesting @barkbay @pebrc ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the lag in answering, not sure myself what would be the best option. I tend to think that https://www.elastic.co/guide/en/elasticsearch/reference/current/autoscaling-deciders.html should be improved as I think most of the readers are interested in which resources are estimated for each tier, not really about a list of the available deciders which should be an implementation detail.
We can use a table, maybe something along the lines of:
As a side note I just realized that https://www.elastic.co/docs/deploy-manage/autoscaling/autoscaling-in-ece-and-ech does not mention the frozen tier case, so maybe you were right in the beginning and It's okay not to be that specific 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think the table format is much clearer to understand as opposed to reading a wall of text. I'll update this updated and we can review further. ty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think this is much more clear: