Skip to content

[Synthetics] Fix async step callback #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

[Synthetics] Fix async step callback #1042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e966a3
Fix async step callback
emilioalvap Apr 7, 2025
16e9898
Merge branch 'main' into synthetics-fix-steps
vigneshshanmugam Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions solutions/observability/apps/write-synthetic-test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ A basic two-step journey would look like this:

```js
journey('Journey name', ({ page, browser, client, params, request }) => {
step('Step 1 name', () => {
step('Step 1 name', async () => {
// Do something here
});
step('Step 2 name', () => {
step('Step 2 name', async () => {
// Do something else here
});
});
Expand All @@ -110,7 +110,7 @@ journey('Journey name', ({ page, browser, client, params, request }) => {
Steps can be as simple or complex as you need them to be. For example, a basic first step might load a web page:

```js
step('Load the demo page', () => {
step('Load the demo page', async () => {
await page.goto('https://elastic.github.io/synthetics-demo/'); <1>
});
```
Expand Down
Loading