Chore: Modify the upgrade docs to clarify the user and pass arguments
#1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shasts
requested review from
florent-leborgne,
kilfoyle,
przemek-grzedzielski and
shainaraskas
Co-authored-by: George Wallace <[email protected]>
jakommo
reviewed
Apr 9, 2025
|
One more thing. Are the 3.8 docs built from this? My understanding was it would only apply to ECE 4.0 docs and later? In any case, I just saw elastic/ansible-elastic-cloud-enterprise#205 (comment) and you had a good point about upgrades using the latest version of the elastic-cloud-enterprise.sh script. So I think we should back port this to earlier 3.x ECE docs as well. |
Co-authored-by: Jakob Reiter <[email protected]>
|
@jakommo No, this would be 4.0 only. For 3.8 we would need to make the updates in asciidoc. If this does relate to 3.8, I can absolutely cover over the contents to a PR there. |
|
@georgewallace |
jakommo
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the
--userand--passarguments required for ECE3.8.0in the simple upgrade step example.