Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Apr 11, 2025

I did a broad search of all the generated HTML for a few patterns that suggested formatting errors. Here are the fixes to the issues I found in this repo.

Note: Some of the changes are subjective (for example, when to use subs=true vs. just hardcoding a term like Elasticsearch in a code comment).

@colleenmcginnis colleenmcginnis self-assigned this Apr 11, 2025
Comment on lines +102 to 109
:::{note}
If the **Reporting** options for application features are unavailable, and the cluster license is higher than Basic, contact your administrator.
:::

:::{image} /deploy-manage/images/kibana-kibana-privileges-with-reporting.png
:alt: {{kib}} privileges with Reporting options, Gold or higher license
:screenshot:
:::
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matter what I tried, I couldn't get the second {note} to render under the image.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review April 11, 2025 22:34
@colleenmcginnis colleenmcginnis requested a review from a team April 11, 2025 22:34
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colleenmcginnis colleenmcginnis enabled auto-merge (squash) April 14, 2025 13:43
@colleenmcginnis colleenmcginnis merged commit 698f710 into main Apr 14, 2025
3 of 4 checks passed
@colleenmcginnis colleenmcginnis deleted the more-fixes branch April 14, 2025 13:45
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blah thank you for this - I just started spotting the places where subs were used in code blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants