apm: Document sampling.tail.ttl config #1269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2025
carsonip
commented
May 6, 2025
carsonip
commented
May 6, 2025
There was a problem hiding this comment.
This looks good to me, but if you don't want this to be published until 9.1 you should hold off on merging as you mentioned.
(Spoiler: We're working on some changes to how to handle PRs like this that contain content for future versions and how to annotate version applicability of individual settings. If these features are available in docs-builder before the 9.1 release, I'll make updates here.)
carsonip
commented
May 21, 2025
1 task
carsonip
commented
May 29, 2025
🔍 Preview links for changed docs |
simitt
reviewed
Jul 7, 2025
Co-authored-by: simitt <[email protected]>
carsonip
commented
Jul 7, 2025
simitt
approved these changes
Jul 8, 2025
isaacaflores2
added a commit
that referenced
this pull request
Jul 28, 2025
Document `sampling.tail.discard_on_write_failure` config. I sourced the config explanation from [here](https://github.com/elastic/apm-server/blob/613b774ba953d159584c666cd7d0753404374318/x-pack/apm-server/sampling/config.go#L115-L118) please let me know if the description is incorrect or unclear in any way. Updated pages can be found in the docs preview here: - https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1453/reference/apm/cloud/apm-settings - https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1453/solutions/observability/apm/tail-based-sampling - https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1453/solutions/observability/apm/configure-apm-server - https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1453/solutions/observability/apm/transaction-sampling#_tail_based_sampling_performance_and_requirements ## Checklist - [ ] Wait for PR #1269 to be merged and incorporate changes. ## Related issues Part of elastic/apm-server#15330 --------- Co-authored-by: Carson Ip <[email protected]> Co-authored-by: florent-leborgne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document
sampling.tail.ttlconfigRelated to #769
Part of elastic/apm-server#13525