-
Notifications
You must be signed in to change notification settings - Fork 163
Create comment-on-removed-files.yml #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
79d6632
Create comment-on-removed-files.yml
bmorelli25 029472d
Update comment-on-removed-files.yml
bmorelli25 ec0c761
test delete and rename
colleenmcginnis f23101a
Revert "test delete and rename"
colleenmcginnis feb09fd
Update comment-on-removed-files.yml
bmorelli25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
name: Comment on removed .md files | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
|
||
jobs: | ||
detect-removed-markdown: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
pull-requests: write | ||
|
||
steps: | ||
- uses: actions/github-script@v7 | ||
with: | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
script: | | ||
const prNumber = context.payload.pull_request.number; | ||
|
||
// Get all files in the PR | ||
const { data: files } = await github.rest.pulls.listFiles({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
pull_number: prNumber | ||
}); | ||
|
||
// Filter for removed .md files | ||
const removedMd = files | ||
.filter(f => f.status === 'removed' && f.filename.endsWith('.md')) | ||
.map(f => `- \`${f.filename}\``); | ||
|
||
// Filter for renamed .md files | ||
const renamedMd = files | ||
.filter(f => f.status === 'renamed' && f.filename.endsWith('.md')) | ||
.map(f => `- \`${f.previous_filename}\` → \`${f.filename}\``); | ||
|
||
// Create a comment if there are any removed or renamed files | ||
if (removedMd.length > 0 || renamedMd.length > 0) { | ||
// Build sections based on what changes were detected | ||
const sections = []; | ||
|
||
// Add removed files section if there are any | ||
if (removedMd.length > 0) { | ||
sections.push( | ||
removedMd.length === 1 | ||
? "The following Markdown file was **removed** in this PR:" | ||
: `The following ${removedMd.length} Markdown files were **removed** in this PR:`, | ||
...removedMd, | ||
"" | ||
); | ||
} | ||
|
||
// Add renamed files section if there are any | ||
if (renamedMd.length > 0) { | ||
sections.push( | ||
renamedMd.length === 1 | ||
? "The following Markdown file was **renamed** in this PR:" | ||
: `The following ${renamedMd.length} Markdown files were **renamed** in this PR:`, | ||
...renamedMd, | ||
"" | ||
); | ||
} | ||
|
||
// Prepare comment body | ||
const body = [ | ||
bmorelli25 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"## :warning: Markdown file changes detected", | ||
"", | ||
...sections, | ||
"### Action Required", | ||
"", | ||
"We currently do not have an easy way to implement redirects for removed or renamed files. If possible, please:", | ||
"", | ||
"- Keep files whenever possible and hide them from the TOC by using [`hidden`](https://elastic.github.io/docs-builder/configure/content-set/navigation/#hidden-files)", | ||
"- Add a notice at the top of the file indicating that the page has moved with a link to the new location", | ||
"- Ensure you've updated `redirects.yml` accordingly if files must be removed or renamed", | ||
"", | ||
"Thank you!" | ||
].join("\n"); | ||
|
||
// Post the comment on the PR | ||
await github.rest.issues.createComment({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
issue_number: prNumber, | ||
body | ||
}); | ||
|
||
console.log("Comment added about renamed or removed Markdown files"); | ||
} else { | ||
console.log("No Markdown files were removed in this PR"); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.