-
Notifications
You must be signed in to change notification settings - Fork 163
CCS version support information #1359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this 8.0-8.17 "Yes" is also wrong. We only support back to 7.17 from 8.0, but not 8.1, following the "previous minor" rule. This is shown correctly on this page: https://www.elastic.co/guide/en/elasticsearch/reference/8.18/modules-cross-cluster-search.html#ccs-supported-configurations
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
You’re right that based on the “previous minor” rule, only 8.0 from the 8.0–8.17 range supports querying 7.17. The table here (compared to the other one) uses a simplified format, where support is marked if any version in the range supports a pairing.
That said, I see how this could be misleading. I’m happy to adjust the structure—for example, breaking out 8.0 into its own row.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve made the changes we discussed:
• 8.0 now has its own row
• 8.17 is split into a separate column for clarity
Here’s the updated version. Let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this has already merged, but isn't the intersection of
8.1-8.17and8.0-8.16still incorrect? It indicates a local8.17can CCS against a remote8.0.Don't we need to list every minor version in the headers as we did in
8.xdocs for complete accuracy?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rseldner shouldn't this page be analogous to the 8.0 version?
https://www.elastic.co/guide/en/elasticsearch/reference/8.0/modules-cross-cluster-search.html#ccs-supported-configurations
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean how it basically shows how any 7.x can CCS any remote 7.x?
I'm not so sure it should because in 8.x we became more restrictive and introduced these rules.
The 7.x docs do not have these same restrictions documented. Example: https://www.elastic.co/guide/en/elasticsearch/reference/7.16/modules-cross-cluster-search.html#ccs-supported-configurations
But I'm not a source of truth on the topic. I just know that the table does not align with the stated rules.
In the interest of keeping the table condensed maybe we could simply add an asterisk and footnote to the
8.1-8.17/8.0-8.16intersection to explain/reiterate the "previous minor" nuance.Otherwise...
I think this monster of a table would be technically correct