Skip to content

Conversation

endorama
Copy link
Contributor

@endorama endorama commented May 5, 2025

A minor change to the data type for sample_rate. We mention that

The sample rate must be greater than or equal to 0 and less than or equal to 1.

which if restricted to an int type would only allow 0 and 1. A more reasonable (unless there is a reason not clear to me) data type here would be float, allowing any decimal precision value, like the 0.01 mentioned as example.

@endorama endorama enabled auto-merge (squash) May 6, 2025 13:11
@benironside benironside requested a review from a team as a code owner July 31, 2025 19:35
@benironside benironside disabled auto-merge July 31, 2025 19:36
Copy link

github-actions bot commented Jul 31, 2025

🔍 Preview links for changed docs

@benironside benironside enabled auto-merge (squash) July 31, 2025 19:40
@benironside benironside merged commit c96ef48 into main Jul 31, 2025
7 of 8 checks passed
@benironside benironside deleted the endorama-patch-1 branch July 31, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants