Skip to content

Conversation

laraMorenoIgle
Copy link
Contributor

@laraMorenoIgle laraMorenoIgle commented May 8, 2025

The example for "Connect to an external monitoring elasticsearch cluster" can lead to confusion or seem to be incorrect (because secretName is used only for metrics and not for logs), so I added a small explanation about what the config in the example does.

The example for "Connect to an external monitoring elasticsearch cluster" can lead to confusion or seem to be incorrect, so I added a small explanation about what the config in the example does
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

laraMorenoIgle and others added 2 commits May 8, 2025 09:45
Small clarification on the example to send monitoring data to another monitoring cluster
Copy link
Contributor Author

@laraMorenoIgle laraMorenoIgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarification on the example to send monitoring data to another cluster

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@laraMorenoIgle laraMorenoIgle merged commit dd27a07 into main May 8, 2025
5 checks passed
@laraMorenoIgle laraMorenoIgle deleted the laraMorenoIgle-patch-1 branch May 8, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants