-
Notifications
You must be signed in to change notification settings - Fork 159
apm: Document sampling.tail.discard_on_write_failure config #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
isaacaflores2
merged 8 commits into
elastic:main
from
isaacaflores2:tbs-config-discard-on-write
Jul 28, 2025
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2ebbf56
apm: Document sampling.tail.discard_on_write_failure config
isaacaflores2 76fadaa
apm: specify sampling bypass when discard_on_write_failure is false
isaacaflores2 ad5d6c0
apm: add discard_on_write_failure note to transaction-sampling.md
isaacaflores2 5f874ab
apm: update discard_on_write_failure descriptions to match writing gu…
isaacaflores2 7041c81
Merge branch 'main' into tbs-config-discard-on-write
isaacaflores2 201df71
Apply suggestions to align with recent changes to the docs
isaacaflores2 0ff93d9
Merge branch 'main' into tbs-config-discard-on-write
florent-leborgne 790e61b
Merge branch 'main' into tbs-config-discard-on-write
isaacaflores2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config also applies to
8.19+
but I left it out based on @carsonip comment in another PR. Let me know if I should add8.19+
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florent-leborgne @colleenmcginnis My initial plan was to backport this PR to 8.X branch for the 8.19 release (and change the versions from 9.1 to 8.19). But I just realized 8.19 is being released before 9.1.
Should I create a separate PR for 8.X? Or do you have any other suggestions? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @isaacaflores2. Thanks for this PR. You would need a different PR anyways for 8.19 docs because:
I am happy to help if you need
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it thanks for sharing. I will start a PR for 8.19 docs in the other repo. I'll reach out on slack for any help