yaml values indentation fixed and aligned with the other oidc page #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shainaraskas
approved these changes
May 26, 2025
|
what is sure is that the previous yaml blocks were incorrect, all of them. I'll do a quick test before merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a bug discovered @rgshenoy in #1416
Replaces #1416
Some indentation in the yaml configuration for Elasticsearch and Kibana was incorrect. We have fixed it and aligned the format with the other OIDC document.
Note that while reviewing all other examples in other realms (LDAP, SAML, etc) there's no alignment at all in the format of the suggested yaml settings. It might be good to align them in a separate PR, although it's not really an issue or important.
cc: @shainaraskas