Skip to content

Adds AutoOps and Stack Monitoring comparison #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2025
Merged

Adds AutoOps and Stack Monitoring comparison #1711

merged 6 commits into from
Jun 16, 2025

Conversation

wajihaparvez
Copy link
Contributor

@wajihaparvez wajihaparvez commented Jun 11, 2025 •
edited
Loading

This PR makes the following changes:

  • adds the AutoOps and Stack Monitoring comparison (preview) to the AutoOps docs
  • references the article on the following pages:
  • makes some clarity edits to the AutoOps FAQ page

Closes: #284

@wajihaparvez wajihaparvez self-assigned this Jun 11, 2025
@wajihaparvez wajihaparvez requested a review from a team as a code owner June 11, 2025 20:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2025 •
edited
Loading

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

@arnonst
Copy link

arnonst commented Jun 12, 2025

@wajihaparvez
Do these sentences start with a capitalized letter?
image

@consulthys
Copy link
Contributor

@arnonst I had them capitalized initially but the previous tech writer lowercased them, so not sure

@shainaraskas shainaraskas self-requested a review June 12, 2025 19:52
@wajihaparvez
Copy link
Contributor Author

@arnonst @consulthys In most cases, we do capitalize the first letter in bullet points. However, the bullet points here are fragments of the introductory sentence that precedes them. So in my opinion, the bullet points should be lowercase since they're a continuation of the introductory sentence. Other writers in @elastic/admin-docs feel free to correct me if I'm wrong :) happy to change this

I do think we can remove the periods at the end of the bullet points for better flow

kilfoyle
kilfoyle approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏎️
Just a few small suggestions. Nice work!!!

shainaraskas
shainaraskas reviewed Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added a couple of high level comments - might come back with some more details but david already took a pass so maybe not!

shainaraskas
shainaraskas reviewed Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added a couple of high level comments - might come back with some more details but david already took a pass so maybe not!

@arnonst
Copy link

arnonst commented Jun 16, 2025

@wajihaparvez - Let's located the new page in Monitoring, below the "Stack Monitoring" page
image

arnonst
arnonst approved these changes Jun 16, 2025
View reviewed changes
Copy link

@arnonst arnonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Need to make sure the page in located in the right place.

shainaraskas
shainaraskas reviewed Jun 16, 2025
View reviewed changes
deploy-manage/monitor/autoops-vs-stack-monitoring.md Outdated
---

# AutoOps and Stack Monitoring comparison
# AutoOps vs. Stack Monitoring
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this title should also change - the vs. is only for brevity in the sidebar, but generally latinisms should be avoided

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with the filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I didn't go with this title originally. Misunderstood your previous comment, but I'll change it back!

@wajihaparvez wajihaparvez enabled auto-merge (squash) June 16, 2025 16:29
@wajihaparvez wajihaparvez merged commit 65aab4f into elastic:main Jun 16, 2025
7 checks passed
@wajihaparvez wajihaparvez deleted the autoops-vs-stack-monitoring branch June 16, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shainaraskas shainaraskas shainaraskas left review comments

@kilfoyle kilfoyle kilfoyle approved these changes

@arnonst arnonst arnonst approved these changes

@consulthys consulthys Awaiting requested review from consulthys

Assignees

@wajihaparvez wajihaparvez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wajihaparvez @arnonst @consulthys @kilfoyle @shainaraskas