-
Notifications
You must be signed in to change notification settings - Fork 159
Expand "Configure a lifecycle policy" docs #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs:
🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this documentation change, I love the new Kibana steps! I just left a few comments.
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilfoyle thank you for doing this, how nice to see it getting some love ❤️ .
I found some spots that might be misleading or incorrect, let me know if you want to go over through some of them offline as well, if that helps.
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Outdated
Show resolved
Hide resolved
@gmarouli and @samxbr Thanks so much for the careful review. 🙏 If you don't mind I'd love if you can take a second look. And do let me know if you don't think the new structure makes sense (I tried to explain the rationale in this comment). |
manage-data/lifecycle/index-lifecycle-management/policy-apply.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/policy-apply.md
Outdated
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Show resolved
Hide resolved
manage-data/lifecycle/index-lifecycle-management/configure-lifecycle-policy.md
Show resolved
Hide resolved
…s.md Co-authored-by: Vlada Chirmicci <[email protected]>
…tatus.md Co-authored-by: Vlada Chirmicci <[email protected]>
…tatus.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
…ecycle-policy.md Co-authored-by: Vlada Chirmicci <[email protected]>
Co-authored-by: Vlada Chirmicci <[email protected]>
…s.md Co-authored-by: Vlada Chirmicci <[email protected]>
Thanks a lot @yetanothertw for the excellent feedback! |
This PR takes a chunk out of internal issue Requested fixes for data lifecycle docs that was initiated by a review of the ILM docs by our Support team.
It updates the "Configure a lifecycle policy" page to:
logs@lifecycle
andmetrics@lifecycle
policies since they affect a LOT of indices.Please see preview pages:
(For reference, here's the original version of the first page).
ES Data Management team, if any of you can please give this a technical review I'd be very grateful! 🙏 The API instructions aren't changed, with the exception that I added this section about calling the ILM explain API. The Kibana steps are all new.