Skip to content

Conversation

florent-leborgne
Copy link
Contributor

@florent-leborgne florent-leborgne commented Jun 25, 2025

This PR documents 9.1 changes made to ES|QL controls in dashboards, and also makes a few small improvements to existing content on that page (like removing useless screenshots and using accessibility-friendly terms like select instead of click)

Closes: #1679

@florent-leborgne florent-leborgne requested review from a team as code owners June 25, 2025 17:48
Copy link

github-actions bot commented Jun 25, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

@florent-leborgne
Copy link
Contributor Author

@stratoula I'd like your take on whether we should dive deeper on certain of these control options. I'm considering several options to restructure the instructions. Let me know what you think or if you have examples in mind you'd like me to add there to support these evolutions.

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, left some small comments.

@florent-leborgne I think they are awesome, I wonder if we can add an example. I had started crafting a blog post https://docs.google.com/document/d/1aYWV1jnVv4H6zQagp1WlpCotwdXxtTHTlp9caxLajMQ which has an example on how to create a date histogram with controlling the interval. Maybe we could use it as an example?

I can think other examples too if you think we want more

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing but nits from me :)

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

florent-leborgne added a commit to elastic/kibana that referenced this pull request Jun 27, 2025
@florent-leborgne florent-leborgne enabled auto-merge (squash) June 27, 2025 14:08
@florent-leborgne florent-leborgne merged commit bb52425 into elastic:main Jun 27, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboards] ES|QL controls creation improvements

4 participants