-
Notifications
You must be signed in to change notification settings - Fork 163
ES|QL dashboard controls in 9.1 #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES|QL dashboard controls in 9.1 #1917
Conversation
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
@stratoula I'd like your take on whether we should dive deeper on certain of these control options. I'm considering several options to restructure the instructions. Let me know what you think or if you have examples in mind you'd like me to add there to support these evolutions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, left some small comments.
@florent-leborgne I think they are awesome, I wonder if we can add an example. I had started crafting a blog post https://docs.google.com/document/d/1aYWV1jnVv4H6zQagp1WlpCotwdXxtTHTlp9caxLajMQ which has an example on how to create a date histogram with controlling the interval. Maybe we could use it as an example?
I can think other examples too if you think we want more
Co-authored-by: Stratoula Kalafateli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing but nits from me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
8.19 equivalent of elastic/docs-content#1917
This PR documents 9.1 changes made to ES|QL controls in dashboards, and also makes a few small improvements to existing content on that page (like removing useless screenshots and using accessibility-friendly terms like select instead of click)
Closes: #1679