-
Notifications
You must be signed in to change notification settings - Fork 163
[ESQL] Improve skip_unavailable
description in CCS doc
#1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
31214cb
1c75606
3bcf536
20aaf55
61ccd82
60c591f
e28d295
c0a615b
b0a78f3
14eabb9
9d1da01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -470,10 +470,27 @@ FROM my-index-000001,cluster*:my-index-*,cluster_three:-my-index-000001 | |||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
## Optional remote clusters [ccq-skip-unavailable-clusters] | ||||||||||||||||||||||||||||
```{applies_to} | ||||||||||||||||||||||||||||
stack: ga 9.1 | ||||||||||||||||||||||||||||
smalyshev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||
``` | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
smalyshev marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||
If the remote cluster is configured with `skip_unavailable: true` (the default setting), the cluster would be set | ||||||||||||||||||||||||||||
to `skipped` or `partial` status but the query will not fail, if: | ||||||||||||||||||||||||||||
smalyshev marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
* The remote cluster is disconnected from the querying cluster, either before or during the query. | ||||||||||||||||||||||||||||
* The remote cluster does not have the requested index. | ||||||||||||||||||||||||||||
* An error happened while processing the query on the remote cluster. | ||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||
The `partial` status will be used if the remote query was partially successful and some data was returned. | ||||||||||||||||||||||||||||
|
The `partial` status will be used if the remote query was partially successful and some data was returned. |
I suggested explaining skipped and partial in the opening section, so can remove this if accept that :)
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first sentence is a little hard to read, I wonder if we can boil it town to a simpler message:
Queries will still fail when skip_unavailable: true
, if none of the specified indices exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a candidate for an admonition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FROM cluster_one:missing-index | LIMIT 10 | |
FROM cluster_one:missing-index* | LIMIT 10 | |
FROM cluster_one:missing-index*,cluster_two:missing-index | LIMIT 10 | |
``` | |
FROM cluster_one:missing-index <1> | |
FROM cluster_one:missing-index* <2> | |
FROM cluster_one:missing-index*,cluster_two:missing-index <3> | |
``` | |
1. Single missing index on one cluster | |
2. Index pattern that matches nothing | |
3. All indices and index patterns missing across every cluster | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
annotating the query might nice, clean way to explain it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the previous text already explains it, do we really need to supply that much detail? It's just different examples of how to write missing indices, after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it hurts to be super clear, and personally I really like annotated examples —specially for non-experts.
But I leave this totally up to your discretion! :)
Uh oh!
There was an error while loading. Please reload this page.