Skip to content

[Security] [July 22] Attack Discovery scheduling and saved discoveries #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 23, 2025
Merged

[Security] [July 22] Attack Discovery scheduling and saved discoveries #2023

merged 10 commits into from
Jul 23, 2025

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Jul 3, 2025 •
edited
Loading

Contributes to #1939 and #1941.
Documents the new Attack Discovery features:

  • Scheduling and notification
  • Viewing historical discoveries

Preview: Attack Discovery

@natasha-moore-elastic natasha-moore-elastic self-assigned this Jul 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025 •
edited
Loading

🔍 Preview links for changed docs

@natasha-moore-elastic natasha-moore-elastic added Serverless Improvements and changes to the Serverless Docs v9.1.0 labels Jul 3, 2025
@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review July 3, 2025 12:46
@natasha-moore-elastic natasha-moore-elastic requested review from a team as code owners July 3, 2025 12:46
florent-leborgne
florent-leborgne reviewed Jul 3, 2025
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question about preview/ga status

andrew-goldstein
andrew-goldstein reviewed Jul 3, 2025
View reviewed changes
andrew-goldstein
andrew-goldstein reviewed Jul 3, 2025
View reviewed changes
andrew-goldstein
andrew-goldstein reviewed Jul 3, 2025
View reviewed changes
e40pud
e40pud reviewed Jul 3, 2025
View reviewed changes
benironside
benironside approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing and formatting LGTM. Clear, useful instructions.

benironside
benironside reviewed Jul 10, 2025
View reviewed changes
@natasha-moore-elastic natasha-moore-elastic changed the title [Security] Attack Discovery scheduling and saved discoveries [Security] [July 22] Attack Discovery scheduling and saved discoveries Jul 17, 2025
e40pud
e40pud reviewed Jul 18, 2025
View reviewed changes
e40pud
e40pud approved these changes Jul 18, 2025
View reviewed changes
Copy link

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great description of the feature! LGTM

andrew-goldstein
andrew-goldstein reviewed Jul 18, 2025
View reviewed changes
andrew-goldstein
andrew-goldstein approved these changes Jul 18, 2025
View reviewed changes
Copy link

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @natasha-moore-elastic for these updates!
LGTM 🚀

@natasha-moore-elastic natasha-moore-elastic mentioned this pull request Jul 23, 2025
Merged
@natasha-moore-elastic natasha-moore-elastic enabled auto-merge (squash) July 23, 2025 15:54
@natasha-moore-elastic natasha-moore-elastic merged commit 4a327cc into main Jul 23, 2025
8 of 9 checks passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-1939-persist-discoveries branch July 23, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florent-leborgne florent-leborgne florent-leborgne left review comments

@benironside benironside benironside approved these changes

@e40pud e40pud e40pud approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

@dhru42 dhru42 Awaiting requested review from dhru42

Assignees

@natasha-moore-elastic natasha-moore-elastic

Labels

Serverless Improvements and changes to the Serverless Docs v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@natasha-moore-elastic @e40pud @andrew-goldstein @florent-leborgne @benironside