-
Notifications
You must be signed in to change notification settings - Fork 163
Add Simplified Linear & RRF Retriever Examples #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Simplified Linear & RRF Retriever Examples #2026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start, a few typos and suggestions on where we can add a bit more
Question for the future: would it be better for the examples page to live in the elasticsearch repo eventually, as in a be a child to the reference page? having the overview page in the search solution/use case makes sense, but then having examples/reference separated feels wrong 🤷♂️ this is an artifact of the docs migration...but we could re-home the page if it that sounds right |
@leemthompo I think it makes sense to make the examples page a child of the reference page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
:::: | ||
|
||
We don't even need to specify the `fields` parameter when using the multi-field query format. | ||
If we omit it, the retriever will automatically query fields specified in the `index.query.default_field` index setting, which is set to `*` by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@elasticmachine update branch |
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mikep86!
Adds simplified
linear
andrrf
retriever examples. Sibling PR to elastic/elasticsearch#130559.