Skip to content

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Jul 3, 2025

Adds simplified linear and rrf retriever examples. Sibling PR to elastic/elasticsearch#130559.

@Mikep86 Mikep86 requested review from kderusso and leemthompo July 3, 2025 14:56
@Mikep86 Mikep86 requested a review from a team as a code owner July 3, 2025 14:56
@Mikep86 Mikep86 added documentation Improvements or additions to documentation v9.1.0 API docs v9.2.0 labels Jul 3, 2025
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, a few typos and suggestions on where we can add a bit more

@leemthompo
Copy link
Contributor

leemthompo commented Jul 3, 2025

@Mikep86 @kderusso

Question for the future: would it be better for the examples page to live in the elasticsearch repo eventually, as in a be a child to the reference page?

having the overview page in the search solution/use case makes sense, but then having examples/reference separated feels wrong 🤷‍♂️

this is an artifact of the docs migration...but we could re-home the page if it that sounds right

@Mikep86
Copy link
Contributor Author

Mikep86 commented Jul 3, 2025

@leemthompo I think it makes sense to make the examples page a child of the reference page

@Mikep86 Mikep86 requested a review from kderusso July 3, 2025 20:43
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

::::

We don't even need to specify the `fields` parameter when using the multi-field query format.
If we omit it, the retriever will automatically query fields specified in the `index.query.default_field` index setting, which is set to `*` by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mikep86
Copy link
Contributor Author

Mikep86 commented Jul 8, 2025

@elasticmachine update branch

Copy link

github-actions bot commented Jul 8, 2025

🔍 Preview links for changed docs

@leemthompo leemthompo enabled auto-merge (squash) July 9, 2025 08:12
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mikep86!

@leemthompo leemthompo merged commit ca82bfc into elastic:main Jul 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API docs documentation Improvements or additions to documentation v9.1.0 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants