Skip to content

Conversation

afoucret
Copy link
Contributor

No description provided.

@afoucret afoucret requested a review from a team as a code owner July 10, 2025 10:28
@github-actions
Copy link

github-actions bot commented Jul 10, 2025

🔍 Preview links for changed docs

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one question about whether the limitations have changed or just re-phrasing that section and one nit :)

4. The number of documents that should be examined by the rescorer.

Scores returned by LTR models are usually not comparable with the scores issued by the first pass query and can be lower than the non-rescored score. This can cause the non-rescored result document to be ranked higher than the rescored document. To prevent this, the `window_size` parameter is mandatory for LTR rescorers and should be greater than or equal to `from + size`.
## Known limitations [learning-to-rank-rescorer-limitations]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just wording changes, or have the limitations changed from 9.0 to 9.1?

  • If it's just wording then that's fine
  • But if the limitations have changed, users need to be able to see both versions, so could use a tabbed widget to distinguish them, or inline applies_to annotations if there are minor differences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rewording

@afoucret afoucret enabled auto-merge (squash) July 10, 2025 12:39
@afoucret afoucret merged commit f8586c4 into elastic:main Jul 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants