Skip to content

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 10, 2025

Copy link

github-actions bot commented Jul 10, 2025

@lcawl lcawl marked this pull request as ready for review July 16, 2025 15:11
@lcawl lcawl requested review from a team as code owners July 16, 2025 15:11
@lcawl lcawl requested review from ketkee-aryamane and marciw July 16, 2025 15:11
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I like the scope of it and it has a nice flow. I made some minor suggestions but some of them really are just preferences, so take or leave them as you see fit!

sorry the comments jump around 🫤 I added a screenshot for the first 2 paragraphs

Copy link
Contributor

@ketkee-aryamane ketkee-aryamane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written! :)) Only nitpicking, take in the suggestions if you want to.

Just out of curiosity, if this content wasn't taken as is, do we test this before we write or do we ask a dev to confirm if everything works correctly as stated here?

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for wading through all my suggestions! LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Jul 17, 2025

Just out of curiosity, if this content wasn't taken as is, do we test this before we write or do we ask a dev to confirm if everything works correctly as stated here?

I tested this all last night and had fun doing so! Generally a good idea to ensure everything we document works--either ourselves or with assistance, as you said.

@lcawl lcawl enabled auto-merge (squash) July 17, 2025 16:02
@lcawl lcawl merged commit 1d3018c into elastic:main Jul 17, 2025
7 of 8 checks passed
@lcawl lcawl deleted the lcawl/gs-python branch July 17, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants