-
Notifications
You must be signed in to change notification settings - Fork 163
add ccs support for 8.19 and 9.1 #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this!
We need to make some adjustments, let me know if you believe I've missed anything!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this @ketkee-aryamane! First off, the table is awful to work with 🤣 and there's additional complexity because 8.18
wasn't 8.last
.
Looking at the new table, it does look like we've introduced an error here: it now states that a local 9.0 is not compatible with a remote 8.18. This contradicts the explicit example text "For example, a local 9.0 cluster can search a remote 8.18 or any remote 9.x cluster. "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a pending change that I've added in a comment.
About the note I think we should update the link and not linking to the github page of Elasticsearch from our official docs. If feels really weird. But I'm not sure where to link at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment on the missing references
| 8.18 |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  | | ||
| 9.0 |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  |  | | ||
|
||
| Local cluster version | 7.17 | 8.0 | 8.1 | 8.2 | 8.3 | 8.4 | 8.5 | 8.6 | 8.7 | 8.8 | 8.9 | 8.10 | 8.11 | 8.12 | 8.13 | 8.14 | 8.15 | 8.16 | 8.17 | 8.18 | 8.19 | 9.0 | 9.1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ketkee-aryamane I think the table is missing some references. E.g. a local 8.19 is listed as incompatible with a remote on 9.1, 8.x would be compatible with a remote on 8.19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @naj-h following is the updated table, where I do see that 8.19 is listed as compatible with a remote on 9.1, 8.x compatible with a remote on 8.19.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove local 9.0 with remote 8.19
There are some paths that appear are unsupported in the table, for which we're going to double-check, but this might be something we change in the doc in the future, even after the release is out, so i'm good with merging this table (after removing local 9.0 with remote 8.19)
DO NOT MERGE THIS PR UNTIL 9.1 / 8.19 RELEASE DAY
Linked to https://github.com/elastic/developer-docs-team/issues/313
Added versions 8.19 and 9.1 to the table listing support for cross cluster search. The following screenshot gives a preview of the change.
Added the 'applies_to' tag to signify GA for 9.1.