-
Notifications
You must be signed in to change notification settings - Fork 159
FIPS for ingest tools #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIPS for ingest tools #2136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @karenzone for the initial architecture; the split into product categories looks good to me.
Left some initial comments, but I will need to spend more time on finding some more user friendly wording for the removed/changed functionality.
As a general guideline, I would suggest we list the removed functionality as limititation, but do not list configuration options that themselves are just not FIPS compliant. We can do an overall callout on these but would keep this separated from functional limitations. I'll provide more thorough suggestions for this.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored by: Silvia Mitter <[email protected]>
i think it might be good to add a section to the 'FIPS for ingest tools' page for "Integrations". we have several integrations which are currently not FIPS compatible. calling these out here would avoid suprises for customers who don't learn they're unsupported until they try to install them. we list the equivalent metricbeat modules, so it makes sense to also list the Integrations that depend on them. you can see which packages are currently not FIPS compatible by checking the for cc @shmsr |
@tommyers-elastic @shmsr (and others who are interested): |
@karenzone by default we are saying that intergrations are compatible. but the boolean flag itself doesn't really make any promises about compliance - this is handled at the beats level (hence 'compatible', not 'compliant'). the flag is really like a hint for fleet so we can say to the customer "hey this integration isn't gonna work because it depends on modules that are not in the FIPS version of agent". hope that makes sense. |
043bbf1
to
4eaa2ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another round of review and left some small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karenzone as just discussed, added some missing imitations.
Thanks for the suggestion. We worked the content into https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/2136/deploy-manage/security/fips-ingest#ingest-limitations-agent. The query you provided was helpful in compiling the list and links. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for all the work on putting this together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🏎️
Very nice work @karenzone!
Note to reviewers and others who are interestedWe are still collecting info and feedback for a quick-follow PR. |
PREVIEWS:
https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/2136/deploy-manage/security/fips
https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/2136/deploy-manage/security/fips-es
https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/2136/deploy-manage/security/fips-kib
https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/2136/deploy-manage/security/fips-ingest
Related:
Checklist
Deploy and Manage > Security > Secure
your cluster or deployment toDeploy and Manage > Security
to allow for expansion, SEO, and findability.Might happen in another PR.