Skip to content

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Jul 15, 2025

In light of finding abuse of dummy links in our docs, this replaces placeholder URLs with non-hostable segments.

A few thoughts:

  • I noticed that for Cloud API examples we sometimes use COORDINATOR_HOST rather than the variable $COORDINATOR_HOST. The latter is safer, and also we explicitly tell users to export that variable in their shell to run the curl API examples.
  • Some other changes are just for consistency, i.e., using angle brackets for segments that need to be replaced.
  • Where possible I removed http and https from dummy URLs, but in some cases it's explicitly the protocol that's being demonstrated, so I left those and changed the url content to contain angle brackets.

Rel: #1799

Copy link

github-actions bot commented Jul 15, 2025

🔍 Preview links for changed docs

More links …

@kilfoyle kilfoyle marked this pull request as ready for review July 17, 2025 14:08
@kilfoyle kilfoyle requested review from a team as code owners July 17, 2025 14:08
@elastic elastic deleted a comment from github-actions bot Jul 17, 2025
@elastic elastic deleted a comment from github-actions bot Jul 17, 2025
@elastic elastic deleted a comment from github-actions bot Jul 17, 2025
@elastic elastic deleted a comment from github-actions bot Jul 17, 2025
@elastic elastic deleted a comment from github-actions bot Jul 17, 2025
@elastic elastic deleted a comment from github-actions bot Jul 17, 2025
@elastic elastic deleted a comment from github-actions bot Jul 17, 2025
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for files owned by Experience. Thanks!

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh so secure

couple small comments to take or leave

@kilfoyle kilfoyle merged commit 0dd823e into elastic:main Jul 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants