-
Notifications
You must be signed in to change notification settings - Fork 163
Replace placeholder URLs #2141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace placeholder URLs #2141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for files owned by Experience. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh so secure
couple small comments to take or leave
deploy-manage/deploy/elastic-cloud/heroku-getting-started-installing.md
Outdated
Show resolved
Hide resolved
deploy-manage/deploy/elastic-cloud/heroku-working-with-elasticsearch.md
Outdated
Show resolved
Hide resolved
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
In light of finding abuse of dummy links in our docs, this replaces placeholder URLs with non-hostable segments.
A few thoughts:
COORDINATOR_HOST
rather than the variable$COORDINATOR_HOST
. The latter is safer, and also we explicitly tell users to export that variable in their shell to run the curl API examples.http
andhttps
from dummy URLs, but in some cases it's explicitly the protocol that's being demonstrated, so I left those and changed the url content to contain angle brackets.Rel: #1799