-
Notifications
You must be signed in to change notification settings - Fork 159
edit defend advanced options wording #2157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the edits @ferullo! The descriptions are a lot clearer, and I'm definitely in favor of making the structure more parallel.
: Added in 7.11.0. | ||
|
||
*A supplied value will configure logging to syslog. Allowed values are `error`, `warning`, `info`, `debug`, and `trace`.* | ||
* Write logs to syslog. Allowed values are `error`, `warning`, `info`, `debug`, and `trace`. Default: none.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Write logs to syslog. Allowed values are `error`, `warning`, `info`, `debug`, and `trace`. Default: none.* | |
*Write logs to syslog. Allowed values are `error`, `warning`, `info`, `debug`, and `trace`. Default: none.* |
: Added in 8.19.0. | ||
|
||
*If set to `true`, file events include file origin details: file.origin_url, file.origin_referrer_url, and file.Ext.windows.zone_identifier. These fields show the details of file's Mark of the Web. Default: `true`* | ||
*When enabled (`true`), file events include `file.origin_url`, `file.origin_referrer_url`, and `file.Ext.windows.zone_identifier. These fields show the details of file's Mark of the Web. Default: `true`* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*When enabled (`true`), file events include `file.origin_url`, `file.origin_referrer_url`, and `file.Ext.windows.zone_identifier. These fields show the details of file's Mark of the Web. Default: `true`* | |
*Include `file.origin_url`, `file.origin_referrer_url`, and `file.Ext.windows.zone_identifier` in file events. These fields show the details of file's Mark of the Web. Default: `true`* |
: Added in 8.19.0. | ||
|
||
*Controls whether Microsoft-Windows-Security-Auditing ETW provider is enabled for security events collection. Set to `false` to disable the provider. Default: `true`.* | ||
*Controls whether Microsoft-Windows-Security-Auditing ETW provider is enabled for security events collection. Set to `false` to disable the provider. Default: `true`.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Controls whether Microsoft-Windows-Security-Auditing ETW provider is enabled for security events collection. Set to `false` to disable the provider. Default: `true`.* | |
*Enable the Microsoft-Windows-Security-Auditing ETW provider for security events collection. Default: `true`.* |
: Added in 8.16.0. | ||
|
||
*Controls whether malware protection is applied to dev drives. Default: `false`.* | ||
*Control whether malware protection is applied to dev drives. Default: `false`.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Control whether malware protection is applied to dev drives. Default: `false`.* | |
*Apply malware protection to dev drives. Default: `false`.* |
: Added in 8.15.0. | ||
|
||
*Controls whether the kernel reports loopback network events. Default: `true`.* | ||
*Control whether loopback network events are reported. Default: `true`.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Control whether loopback network events are reported. Default: `true`.* | |
*Report loopback network events. Default: `true`.* |
: Added in 8.9.0. | ||
|
||
*Controls whether malware protection is applied to network drives. Default: `true`.* | ||
*Control whether malware protection is applied to network drives. Default: `true`.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Control whether malware protection is applied to network drives. Default: `true`.* | |
*Apply malware protection to network drives. Default: `true`.* |
Co-authored-by: natasha-moore-elastic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review! I accepted all your suggestions and added suggestions I think will address your outstanding comments.
Co-authored-by: Daniel Ferullo <[email protected]>
LGTM! |
@natasha-moore-elastic am I correct to assume it's ok for me to merge this? |
@ferullo, all good on my end! I'll go ahead and merge. |
This edits the Defend advanced option wording with the following primary goals:
Originally we'd agreed to completely remove the italics portion on this page and make sure the Kibana tool tips were "short" with an expectation users turn to this more detailed documentation when needed. I tried, but was only as successful as what I'm proposing to merge in this PR (usually shorten the italics tool tip and always still show it on elastic.co).
Thoughts @natasha-moore-elastic @gabriellandau @roxana-gheorghe @nfritts @joe-desimone
Docs Preview as of July 28