Skip to content

Add docs for async stop command #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2025
Merged

Add docs for async stop command #2181

merged 8 commits into from
Jul 22, 2025

Conversation

smalyshev
Copy link
Contributor

No description provided.

@smalyshev smalyshev requested review from a team as code owners July 19, 2025 01:25
@smalyshev smalyshev requested a review from naj-h July 19, 2025 01:25
@smalyshev smalyshev added the documentation Improvements or additions to documentation label Jul 19, 2025
@github-actions
Copy link

github-actions bot commented Jul 19, 2025 •
edited
Loading

🔍 Preview links for changed docs

naj-h
naj-h requested changes Jul 21, 2025
View reviewed changes
Copy link

@naj-h naj-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit to clarify the phrasing. Otherwise LGTM

leemthompo
leemthompo reviewed Jul 21, 2025
View reviewed changes
leemthompo
leemthompo reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions and I agree with @naj-h's rephrasing 👍

@smalyshev smalyshev requested review from leemthompo and naj-h July 21, 2025 18:58
leemthompo
leemthompo approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

florent-leborgne
florent-leborgne approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

naj-h
naj-h approved these changes Jul 22, 2025
View reviewed changes
Copy link

@naj-h naj-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smalyshev smalyshev enabled auto-merge (squash) July 22, 2025 15:45
@smalyshev smalyshev merged commit fb356dd into main Jul 22, 2025
7 checks passed
@smalyshev smalyshev deleted the asyc-query branch July 22, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florent-leborgne florent-leborgne florent-leborgne approved these changes

@leemthompo leemthompo leemthompo approved these changes

@naj-h naj-h naj-h approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smalyshev @florent-leborgne @leemthompo @naj-h