Skip to content

Conversation

sodhikirti07
Copy link
Contributor

Description

This PR adds columns for supported integrations and OS types to the Prebuilt ML jobs table.

Related Issue

@sodhikirti07 sodhikirti07 requested a review from a team as a code owner July 24, 2025 15:09
Copy link

github-actions bot commented Jul 24, 2025

🔍 Preview links for changed docs

@jmcarlock
Copy link
Contributor

jmcarlock commented Jul 24, 2025

  • Verified accuracy of the integrations according to the internal spreadsheet
  • For AWS the link should be the AWS Cloudtrail integration
  • @susan-shu-c does LotL support Linux?
  • For formatting, perhaps we merge the code/datafeed columns with links for both. I will defer to @elastic/developer-docs for suggestions. It's fairly difficult to read right now

@susan-shu-c
Copy link
Member

susan-shu-c commented Jul 24, 2025

@susan-shu-c does LotL support Linux?

Good question, it is Windows only at the moment

@sodhikirti07
Copy link
Contributor Author

Good question, it is Windows only at the moment

Thanks for flagging, lotl is windows only for now. I'll change it.

Copy link
Member

@susan-shu-c susan-shu-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes for Living off the Land

I agree with this point via Gus

For formatting, perhaps we merge the code/datafeed columns with links for both. I will defer to @elastic/developer-docs for suggestions. It's fairly difficult to read right now

Looking at the preview page, it's really odd that the first column takes up so much horizontal space, leaving the Description to be quite cramped 😅

Screenshot 2025-07-25 at 9 45 08 AM

I think it's worth doing a best-effort investigation into improving the format and perhaps reducing column count while keeping the same level of information, but we can see if you run into blockers there.

@sodhikirti07
Copy link
Contributor Author

@elastic/developer-docs Could someone take a look at this PR?

@sodhikirti07
Copy link
Contributor Author

@natasha-moore-elastic Could you review this PR?

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup LGTM!
I'd defer to @nastasha-solomon for a more thorough review as she knows the context way better than me.

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggested change

| suspicious_login_activity | Detect unusually high number of authentication attempts. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/suspicious_login_activity.json)| [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_suspicious_login_activity.json)|
| Name | Description | Job (JSON) | Datafeed | Supported Integrations | Supported OS |
| --- | --- | --- | --- |-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| --- |
| auth_high_count_logon_events | Looks for an unusually large spike in successful authentication events. This can be due to password spraying, user enumeration, or brute force activity. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/auth_high_count_logon_events.json) | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_auth_high_count_logon_events.json)| [System](https://www.elastic.co/docs/reference/integrations/system), [Elastic Defend (endpoint)](https://www.elastic.co/docs/reference/integrations/endpoint), [Winlogbeat](https://www.elastic.co/docs/reference/beats/winlogbeat/), [Windows](https://www.elastic.co/docs/reference/integrations/windows) | windows |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| auth_high_count_logon_events | Looks for an unusually large spike in successful authentication events. This can be due to password spraying, user enumeration, or brute force activity. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/auth_high_count_logon_events.json) | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_auth_high_count_logon_events.json)| [System](https://www.elastic.co/docs/reference/integrations/system), [Elastic Defend (endpoint)](https://www.elastic.co/docs/reference/integrations/endpoint), [Winlogbeat](https://www.elastic.co/docs/reference/beats/winlogbeat/), [Windows](https://www.elastic.co/docs/reference/integrations/windows) | windows |
| auth_high_count_logon_events | Looks for an unusually large spike in successful authentication events. This can be due to password spraying, user enumeration, or brute force activity. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/auth_high_count_logon_events.json) | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_auth_high_count_logon_events.json)| [System](https://www.elastic.co/docs/reference/integrations/system), [{{elastic-defend}}](https://www.elastic.co/docs/reference/integrations/endpoint), [Winlogbeat](https://www.elastic.co/docs/reference/beats/winlogbeat/), [Windows](https://www.elastic.co/docs/reference/integrations/windows) | windows |

Can we make this change in all other occurrences of "Elastic Defend (endpoint)"? We don't really refer to the Elastic Defend integration as 'endpoint' anywhere else in the docs.

@sodhikirti07 sodhikirti07 merged commit 16ef38e into main Jul 29, 2025
8 checks passed
@sodhikirti07 sodhikirti07 deleted the add-supported-integrations-for-ootb-ml branch July 29, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants