-
Notifications
You must be signed in to change notification settings - Fork 163
Add supported integrations and OS for Prebuilt ML jobs #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
|
Good question, it is Windows only at the moment |
Thanks for flagging, lotl is windows only for now. I'll change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes for Living off the Land
I agree with this point via Gus
For formatting, perhaps we merge the code/datafeed columns with links for both. I will defer to @elastic/developer-docs for suggestions. It's fairly difficult to read right now
Looking at the preview page, it's really odd that the first column takes up so much horizontal space, leaving the Description to be quite cramped 😅

I think it's worth doing a best-effort investigation into improving the format and perhaps reducing column count while keeping the same level of information, but we can see if you run into blockers there.
@elastic/developer-docs Could someone take a look at this PR? |
@natasha-moore-elastic Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markup LGTM!
I'd defer to @nastasha-solomon for a more thorough review as she knows the context way better than me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggested change
| suspicious_login_activity | Detect unusually high number of authentication attempts. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/suspicious_login_activity.json)| [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_suspicious_login_activity.json)| | ||
| Name | Description | Job (JSON) | Datafeed | Supported Integrations | Supported OS | | ||
| --- | --- | --- | --- |-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| --- | | ||
| auth_high_count_logon_events | Looks for an unusually large spike in successful authentication events. This can be due to password spraying, user enumeration, or brute force activity. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/auth_high_count_logon_events.json) | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_auth_high_count_logon_events.json)| [System](https://www.elastic.co/docs/reference/integrations/system), [Elastic Defend (endpoint)](https://www.elastic.co/docs/reference/integrations/endpoint), [Winlogbeat](https://www.elastic.co/docs/reference/beats/winlogbeat/), [Windows](https://www.elastic.co/docs/reference/integrations/windows) | windows | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| auth_high_count_logon_events | Looks for an unusually large spike in successful authentication events. This can be due to password spraying, user enumeration, or brute force activity. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/auth_high_count_logon_events.json) | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_auth_high_count_logon_events.json)| [System](https://www.elastic.co/docs/reference/integrations/system), [Elastic Defend (endpoint)](https://www.elastic.co/docs/reference/integrations/endpoint), [Winlogbeat](https://www.elastic.co/docs/reference/beats/winlogbeat/), [Windows](https://www.elastic.co/docs/reference/integrations/windows) | windows | | |
| auth_high_count_logon_events | Looks for an unusually large spike in successful authentication events. This can be due to password spraying, user enumeration, or brute force activity. | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/auth_high_count_logon_events.json) | [code](https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security_auth/ml/datafeed_auth_high_count_logon_events.json)| [System](https://www.elastic.co/docs/reference/integrations/system), [{{elastic-defend}}](https://www.elastic.co/docs/reference/integrations/endpoint), [Winlogbeat](https://www.elastic.co/docs/reference/beats/winlogbeat/), [Windows](https://www.elastic.co/docs/reference/integrations/windows) | windows | |
Can we make this change in all other occurrences of "Elastic Defend (endpoint)"? We don't really refer to the Elastic Defend integration as 'endpoint' anywhere else in the docs.
Description
This PR adds columns for supported integrations and OS types to the Prebuilt ML jobs table.
Related Issue