-
Notifications
You must be signed in to change notification settings - Fork 182
minor defend advanced option clarifications #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
Merged
1 task
natasha-moore-elastic
approved these changes
Aug 1, 2025
Contributor
Author
|
Thanks @natasha-moore-elastic ! I'll merge this when I merge the Kibana PR so I don't come back with another PR to this file 😄 |
Contributor
|
Hey @ferullo, are we good to merge this PR? Asking since it's 1,5 month old now :) |
Contributor
Author
|
I was waiting to merge a Kibana PR at the same time. But that PR is going to be delayed even longer. This can merge now. |
ferullo
added a commit
to elastic/kibana
that referenced
this pull request
Nov 12, 2025
…entation (#230269) ## Summary This aligns the tool-tips shown in Kibana to the same Docs-Team-approved-text on https://www.elastic.co/docs/reference/security/defend-advanced-settings (including a few pending updates in elastic/docs-content#2365). One new advanced option is added. It's been missing from Kibana -- it isn't new. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) ### Identify risks No risk assuming this renders right in Kibana. It's just tool-tip wording changes. --------- Co-authored-by: Ash <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
…entation (elastic#230269) ## Summary This aligns the tool-tips shown in Kibana to the same Docs-Team-approved-text on https://www.elastic.co/docs/reference/security/defend-advanced-settings (including a few pending updates in elastic/docs-content#2365). One new advanced option is added. It's been missing from Kibana -- it isn't new. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) ### Identify risks No risk assuming this renders right in Kibana. It's just tool-tip wording changes. --------- Co-authored-by: Ash <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my last PR to this file I missed a few places clarification was needed. I found them when going through this file again to align Kibana tool tips to it.