-
Notifications
You must be signed in to change notification settings - Fork 159
added sections and references in credentials handling in ECK #2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We will add a comment and some references for external realms also, even if they are not handled by ECK features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small comments alongside linking to external realm docs :)
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Show resolved
Hide resolved
…redentials-eck.md Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
## Creating custom roles | ||
|
||
Roles can be specified using the Role management API, or the Role management UI in {{kib}}. Additionally, file-based role management can be achieved by referencing Kubernetes secrets containing the roles specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would mention the Kubernetes Secrets first. The reason is that being able to create users and roles in a declarative way is more aligned with how resources are managed in Kubernetes. I feel like manually interacting with a web ui is the last thing you want to do when you setup something in K8s (maybe I'm biased by all these years spent on Kubernetes 😄 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, makes sense! I'll rephrase that a bit :)
I just took the same approach as in the original doc, but it's true that the original doc then provided all examples with secrets after the initial sentence.
|
||
Refer to [Native user authentication](/deploy-manage/users-roles/cluster-or-deployment-auth/native.md) for more details. | ||
|
||
### File realm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the same reasons I would move this one before Native realm
.
@barkbay , review this whenever you have time, no rush. Besides the new content, try the links to see if the navigation experience makes sense (for file realm and custom roles mainly) I know in the past we had all the content and examples in the same ECK-focused doc, but hopefully the current links still create a similar experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR improves ECK managed credentials doc, with:
Preview