Skip to content

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Aug 1, 2025

This PR improves ECK managed credentials doc, with:

Preview

@eedugon eedugon requested a review from a team as a code owner August 1, 2025 15:38
Copy link

github-actions bot commented Aug 1, 2025

@eedugon
Copy link
Contributor Author

eedugon commented Aug 1, 2025

We will add a comment and some references for external realms also, even if they are not handled by ECK features.

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small comments alongside linking to external realm docs :)

@eedugon eedugon requested a review from barkbay August 8, 2025 09:55
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Creating custom roles

Roles can be specified using the Role management API, or the Role management UI in {{kib}}. Additionally, file-based role management can be achieved by referencing Kubernetes secrets containing the roles specification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would mention the Kubernetes Secrets first. The reason is that being able to create users and roles in a declarative way is more aligned with how resources are managed in Kubernetes. I feel like manually interacting with a web ui is the last thing you want to do when you setup something in K8s (maybe I'm biased by all these years spent on Kubernetes 😄 ).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, makes sense! I'll rephrase that a bit :)

I just took the same approach as in the original doc, but it's true that the original doc then provided all examples with secrets after the initial sentence.


Refer to [Native user authentication](/deploy-manage/users-roles/cluster-or-deployment-auth/native.md) for more details.

### File realm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the same reasons I would move this one before Native realm.

@eedugon
Copy link
Contributor Author

eedugon commented Aug 8, 2025

@barkbay , review this whenever you have time, no rush. Besides the new content, try the links to see if the navigation experience makes sense (for file realm and custom roles mainly)

I know in the past we had all the content and examples in the same ECK-focused doc, but hopefully the current links still create a similar experience.

@eedugon eedugon requested a review from barkbay August 8, 2025 14:25
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eedugon eedugon enabled auto-merge (squash) August 8, 2025 16:57
@eedugon eedugon merged commit ff063c6 into main Aug 8, 2025
6 checks passed
@eedugon eedugon deleted the eck_users_roles_redirect branch August 8, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants