Skip to content

Conversation

ketkee-aryamane
Copy link
Contributor

Linked to https://github.com/elastic/developer-docs-team/issues/314 and includes fixes for API quickstarts:
Minor rephrasing of sentences
Shortened sentences
Fixes for broken links

Also, removed the redundant migrated content after the main header in explore-analyze/query-filter/languages/querydsl.md

@ketkee-aryamane ketkee-aryamane requested review from a team as code owners August 1, 2025 17:50
Copy link

github-actions bot commented Aug 1, 2025

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here for the exp-docs ✅ (which I guess happened because of the querydsl file? A couple quick suggestions from me, but I’ll leave the bulk of the review to the Core Docs team.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you for these fixes. I left a few nits, please take or leave them. LGTM!

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, spotted couple minor things :)

Comment on lines -14 to -18
$$$filter-context$$$

$$$query-dsl-allow-expensive-queries$$$

$$$relevance-scores$$$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure we want to delete these, the syntax was used to maintain IDs in migration but if there isn't any CI errors, I guess it's OK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. After I removed those, the broken links for those titles started working too. Let me know if we need to confirm about this from someone else too.

@ketkee-aryamane ketkee-aryamane merged commit f324b01 into main Aug 11, 2025
7 checks passed
@ketkee-aryamane ketkee-aryamane deleted the 314-minor-fixes-for-guides branch August 11, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants