-
Notifications
You must be signed in to change notification settings - Fork 159
314 minor fixes for guides #2371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here for the exp-docs ✅ (which I guess happened because of the querydsl file? A couple quick suggestions from me, but I’ll leave the bulk of the review to the Core Docs team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for these fixes. I left a few nits, please take or leave them. LGTM!
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: István Zoltán Szabó <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, spotted couple minor things :)
$$$filter-context$$$ | ||
|
||
$$$query-dsl-allow-expensive-queries$$$ | ||
|
||
$$$relevance-scores$$$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure we want to delete these, the syntax was used to maintain IDs in migration but if there isn't any CI errors, I guess it's OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. After I removed those, the broken links for those titles started working too. Let me know if we need to confirm about this from someone else too.
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
… 314-minor-fixes-for-guides
Co-authored-by: Brandon Morelli <[email protected]>
Linked to https://github.com/elastic/developer-docs-team/issues/314 and includes fixes for API quickstarts:
Minor rephrasing of sentences
Shortened sentences
Fixes for broken links
Also, removed the redundant migrated content after the main header in
explore-analyze/query-filter/languages/querydsl.md