Fix(ECH): Misleading indentation of titles in GCS snapshot repo setup #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
🔍 Preview links for changed docs |
Collaborator
|
hi @mveroone, thanks for your contribution! Can you sign the CLA so I can get your change merged? Looks like we'll need similar fixes for the other repo types - I'll log an issue for that. |
shainaraskas
approved these changes
Aug 6, 2025
Author
|
Sorry for the delay, @shainaraskas , I had completely forgotten about this PR and am getting way too many notification to be able to follow them. However, I see that #2601 had removed that presumably obsolete section. so my PR might deserve to be simply closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current title structure suggests the later 2 sections apply only for versions <7.17, which they don't.