-
Notifications
You must be signed in to change notification settings - Fork 159
1924 fix screenshot #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1924 fix screenshot #2528
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few minor suggestions for your consideration.
I think some of the new screenshots should be cropped. For example in kibana-api-keys-search-bar
, the new version shows a lot more of the page than the previous one. It would be better to focus more on the search, since that's what the screenshot is meant to illustrate.
For kibana-cloud-id, it's good that we're replacing the dark mode screenshot with a light mode one, and I also think it would be good to cut out the left-hand navigation menu, both for maintainability (that menu changes) and to focus on what we're trying to show. Actually it looks like a lot of the screenshots show the left-hand nav, I'd recommend cropping that in all of them.
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice edits :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small suggestion
One nit about PR titles in general: they should be informative, something like: Not sure why |
Ok |
Fixes #2529 by updating the Security AI Assistant's Knowledge Base page, adding more detail about how to add data to KB. Also creates a new example / tutorial page for adding info to Knowledge Base, designed to help users get a practical idea of how to use the Knowledge Base, and showcasing an excellent demo video. Also fixes #2528 by updating the "Add index" to KB section to inform users that starting with 9.1, text fields can be used instead of semantic text fields for helping AI Assistant decide which knowledge entries to refer to. --------- Co-authored-by: Mike Birnstiehl <[email protected]> Co-authored-by: Garrett Spong <[email protected]>
linked to #1924 and includes:
Updated screenshots and steps to show Cloud ID and creating API keys for cloud hosted and serverless deployments.
Minor edits on the page as well.