Skip to content

Conversation

ketkee-aryamane
Copy link
Contributor

linked to #1924 and includes:
Updated screenshots and steps to show Cloud ID and creating API keys for cloud hosted and serverless deployments.
Minor edits on the page as well.

@ketkee-aryamane ketkee-aryamane requested review from a team as code owners August 12, 2025 17:06
@ketkee-aryamane ketkee-aryamane requested a review from ppf2 August 12, 2025 17:07
Copy link

github-actions bot commented Aug 12, 2025

🔍 Preview links for changed docs

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few minor suggestions for your consideration.

I think some of the new screenshots should be cropped. For example in kibana-api-keys-search-bar, the new version shows a lot more of the page than the previous one. It would be better to focus more on the search, since that's what the screenshot is meant to illustrate.

For kibana-cloud-id, it's good that we're replacing the dark mode screenshot with a light mode one, and I also think it would be good to cut out the left-hand navigation menu, both for maintainability (that menu changes) and to focus on what we're trying to show. Actually it looks like a lot of the screenshots show the left-hand nav, I'd recommend cropping that in all of them.

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice edits :)

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small suggestion

@leemthompo
Copy link
Contributor

leemthompo commented Aug 13, 2025

One nit about PR titles in general: they should be informative, something like: Fix screenshots on Elasticsearch connection details page

Not sure why 1924 is in the title either TBH, linking to the related issue in the description suffices, I'm not sure it's useful to have it in the PR title. :)

@ketkee-aryamane
Copy link
Contributor Author

One nit about PR titles in general: they should be informative, something like: Fix screenshots on Elasticsearch connection details page

Not sure why 1924 is in the title either TBH, linking to the related issue in the description suffices, I'm not sure it's useful to have it in the PR title. :)

Ok

@ketkee-aryamane ketkee-aryamane merged commit 2592ff3 into main Aug 18, 2025
8 checks passed
@ketkee-aryamane ketkee-aryamane deleted the 1924-fix-screenshot branch August 18, 2025 09:56
benironside added a commit that referenced this pull request Aug 21, 2025
Fixes #2529 by updating the Security AI Assistant's Knowledge Base page,
adding more detail about how to add data to KB. Also creates a new
example / tutorial page for adding info to Knowledge Base, designed to
help users get a practical idea of how to use the Knowledge Base, and
showcasing an excellent demo video.

Also fixes #2528 by updating the "Add index" to KB section to inform
users that starting with 9.1, text fields can be used instead of
semantic text fields for helping AI Assistant decide which knowledge
entries to refer to.

---------

Co-authored-by: Mike Birnstiehl <[email protected]>
Co-authored-by: Garrett Spong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants