Skip to content

Add groups workaround for BYOK GCP config #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 19, 2025
Merged

Add groups workaround for BYOK GCP config #2613

merged 3 commits into from
Aug 19, 2025

Conversation

shainaraskas
Copy link
Collaborator

image

@shainaraskas shainaraskas requested a review from a team as a code owner August 18, 2025 18:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

🔍 Preview links for changed docs

alxchalkias
alxchalkias approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@alxchalkias alxchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kilfoyle
kilfoyle approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦕

It's outside the scope of this issue, but it would be nice for this page to use tab sets so that the aws/azure/gcp selection persists across all tab sections on the page.

@shainaraskas shainaraskas enabled auto-merge (squash) August 19, 2025 15:34
@shainaraskas shainaraskas merged commit 8fefdc7 into main Aug 19, 2025
6 checks passed
@shainaraskas shainaraskas deleted the gcp-byok-limitation branch August 19, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxchalkias alxchalkias alxchalkias approved these changes

@kilfoyle kilfoyle kilfoyle approved these changes

@yang-wei yang-wei Awaiting requested review from yang-wei

@SpencerLN SpencerLN Awaiting requested review from SpencerLN

@matt-elastic matt-elastic Awaiting requested review from matt-elastic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shainaraskas @alxchalkias @kilfoyle