Skip to content

Adds comment about data sampling time + general enhancements #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 22, 2025
Merged

Adds comment about data sampling time + general enhancements #2639

merged 6 commits into from
Aug 22, 2025

Conversation

@wajihaparvez
Copy link
Contributor

@wajihaparvez wajihaparvez commented Aug 20, 2025 •
edited
Loading

This PR adds a comment about data sampling time to the Events page. I also made the following enhancements:

  • Added more details about what events are and where users can find them
  • Reorganized info to clarify how users can interact with events/perform related actions
  • Removed the Dismiss events page (and set up a redirect for it) + added that info as a section on the Events page
  • Made the Event Settings and Notification Settings pages children of the Events page
  • Made general clarity and style guide edits

Closes: https://github.com/elastic/autoops-services/issues/2275 and #2140

@wajihaparvez wajihaparvez requested a review from arnonst August 20, 2025 19:53
@wajihaparvez wajihaparvez self-assigned this Aug 20, 2025
@wajihaparvez wajihaparvez requested a review from a team as a code owner August 20, 2025 19:53
@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

🔍 Preview links for changed docs

kilfoyle
kilfoyle reviewed Aug 20, 2025
View reviewed changes
kilfoyle
kilfoyle approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌵
Just one wee small suggestion.

benironside
benironside reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Very clear overall. Left a few suggestions for your consideration, hope they are helpful!

arnonst
arnonst approved these changes Aug 21, 2025
View reviewed changes
Copy link

@arnonst arnonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wajihaparvez wajihaparvez requested review from a team as code owners August 22, 2025 21:38
@wajihaparvez
Copy link
Contributor Author

wajihaparvez commented Aug 22, 2025

I messed something up when fixing the merge conflict. Working on a fix for my fix

bmorelli25
bmorelli25 reviewed Aug 22, 2025
View reviewed changes
@bmorelli25 bmorelli25 force-pushed the autoops-data-sampling-time branch from 0e05370 to c74b347 Compare August 22, 2025 23:13
@wajihaparvez wajihaparvez merged commit b445466 into elastic:main Aug 22, 2025
7 checks passed
@wajihaparvez
Copy link
Contributor Author

wajihaparvez commented Aug 22, 2025

I messed something up when fixing the merge conflict. Working on a fix for my fix

Problem solved, HUGE thanks to @bmorelli25 😌

@wajihaparvez wajihaparvez removed request for a team August 22, 2025 23:24
@wajihaparvez wajihaparvez deleted the autoops-data-sampling-time branch August 22, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@benironside benironside benironside left review comments

@kilfoyle kilfoyle kilfoyle approved these changes

@arnonst arnonst arnonst approved these changes

Assignees

@wajihaparvez wajihaparvez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wajihaparvez @bmorelli25 @kilfoyle @benironside @arnonst