-
Notifications
You must be signed in to change notification settings - Fork 159
Refactor ES|QL section #2658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ES|QL section #2658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving with a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we are ready to get rid of the ESQL overview page in this section, given that the rest of the section is positioned as a comparative overview.
at the very minimum, we can't rely on one inline link in the overview to link out to the reference. we need an h2 that says "LEARN HOW TO USE ESQL FOR ELASTICSEARCH" really prominently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that overview page now lives here: https://www.elastic.co/docs/reference/query-languages/esql
the ESQL footprint in E&A is not about ESQL everywhere per Florent's desire to make E&A == Kibana
We need to do similar cleanup for the other query languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the very minimum, we can't rely on one inline link in the overview to link out to the reference. we need an h2 that says "LEARN HOW TO USE ESQL FOR ELASTICSEARCH" really prominently.
this is can do 👍
…n the future i promise
As per elastic/docs-content#2658 Certain links to `docs-content` redirect/rewrite themselves back into documentation now living in `elasticsearch`. To ensure these resolve this now ensures we fetch elasticsearch's own crosslinks. cc @leemthompo
As per elastic/docs-content#2658 Certain links to `docs-content` redirect/rewrite themselves back into documentation now living in `elasticsearch`. To ensure these resolve this now ensures we fetch elasticsearch's own crosslinks. cc @leemthompo
follow up to: elastic#133301 elastic/docs-content#2658 (cherry picked from commit 69274e3)
follow up to: #133301 elastic/docs-content#2658 (cherry picked from commit 69274e3)
Uh oh!
There was an error while loading. Please reload this page.