Skip to content

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Aug 21, 2025

@leemthompo leemthompo self-assigned this Aug 21, 2025
@leemthompo leemthompo marked this pull request as ready for review August 25, 2025 09:52
@leemthompo leemthompo requested review from a team as code owners August 25, 2025 09:52
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with a comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that we are ready to get rid of the ESQL overview page in this section, given that the rest of the section is positioned as a comparative overview.

at the very minimum, we can't rely on one inline link in the overview to link out to the reference. we need an h2 that says "LEARN HOW TO USE ESQL FOR ELASTICSEARCH" really prominently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that overview page now lives here: https://www.elastic.co/docs/reference/query-languages/esql

the ESQL footprint in E&A is not about ESQL everywhere per Florent's desire to make E&A == Kibana

We need to do similar cleanup for the other query languages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the very minimum, we can't rely on one inline link in the overview to link out to the reference. we need an h2 that says "LEARN HOW TO USE ESQL FOR ELASTICSEARCH" really prominently.

this is can do 👍

@leemthompo leemthompo enabled auto-merge (squash) August 25, 2025 14:29
@leemthompo leemthompo merged commit d3231b9 into main Aug 25, 2025
6 of 7 checks passed
@leemthompo leemthompo deleted the leemthompo/esql-explore-analyze-this-starring-robert-deniro branch August 25, 2025 14:31
Mpdreamz added a commit to elastic/elasticsearch that referenced this pull request Aug 25, 2025
As per elastic/docs-content#2658 
Certain links to `docs-content` redirect/rewrite themselves back into documentation now living in `elasticsearch`.

To ensure these resolve this now ensures we fetch elasticsearch's own crosslinks. 

cc @leemthompo
leemthompo pushed a commit to elastic/elasticsearch that referenced this pull request Aug 25, 2025
As per elastic/docs-content#2658 
Certain links to `docs-content` redirect/rewrite themselves back into documentation now living in `elasticsearch`.

To ensure these resolve this now ensures we fetch elasticsearch's own crosslinks. 

cc @leemthompo
leemthompo added a commit to elastic/elasticsearch that referenced this pull request Aug 26, 2025
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Sep 1, 2025
elasticsearchmachine pushed a commit to elastic/elasticsearch that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants