-
Notifications
You must be signed in to change notification settings - Fork 159
[Private preview] Convert Cloud Connect dropdowns to lists #2717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Private preview] Convert Cloud Connect dropdowns to lists #2717
Conversation
@wajihaparvez Can you make the questions more prominent (like having the text in Bold) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a suggestion
deploy-manage/cloud-connect.md
Outdated
|
||
:::{dropdown} Does using Cloud Connect require additional payment? | ||
|
||
### Does using Cloud Connect require additional payment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd pick one or the other - either definition lists or headings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted definition lists throughout, but the build kept failing when I had a definition list on the Cloud Connect page. After a lot of failed troubleshooting, I decided to go with headings for this page. I'll try again now 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wiiiiild
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lmk if you want another set of eyes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done 🎉 Not sure what the problem was, but I deleted the whole thing and wrote it from scratch and now it works
I had originally presented all Cloud Connect FAQs and troubleshooting in dropdowns for better readability. But currently, text inside collapsed dropdowns is not searchable with ctrl+f or cmd+f.
This PR converts all those dropdowns to lists to make the content searchable.
Closes #2693