-
Notifications
You must be signed in to change notification settings - Fork 159
Add time series data stream quickstart #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marciw, looks great!
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marciw, looks great & I really like how the stepper looks.
I have added an optional minor comment about a tip that I may have missed on my last pass. Yours to think whether it makes sense to update.
@kkrik-es adding you as an additional reviewer for your info and a second pair of eyes if you have some time to go through this update: |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🦖
Very, very nice @marciw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I have one minor suggestion for refactoring the sample data step, and couple other tiny ideas. 👍
Co-authored-by: Liam Thompson <[email protected]>
(Replaces #3222, which was an ominshambles) This PR restructures and edits time series data stream docs as part of #1502. ❗ Notes for reviewers: - Changes were approved by Product and Engineering in #3222 🙈 - The content is "MVP" quality overall. More improvements coming soon via the [follow-up issue](#3179), including reconciling the time series section with recent similar changes to the general data stream docs - The various `applies_to` thingies could probably be better; I am committed to maintaining the thinnest of grasps on `applies_to` metadata Summary of changes: - Accuracy updates by SME reviewers/contributors - Many edits for clarity, conciseness, and user focus - Mentions of new ES|QL TS command (which was one of the primary motivators for cleaning up this section) - See also #2274 and #2742 --------- Co-authored-by: David Kilfoyle <[email protected]> Co-authored-by: Liam Thompson <[email protected]>
This PR adds a quickstart to the time series data stream docs.
(The content was developed separately in a Gdoc, with input from product and engineering.)
closes #2741