Skip to content

Conversation

Copy link

github-actions bot commented Sep 10, 2025

🔍 Preview links for changed docs

@shainaraskas shainaraskas marked this pull request as ready for review September 10, 2025 19:31
@shainaraskas shainaraskas requested a review from a team as a code owner September 10, 2025 19:31
Copy link
Contributor

@alxchalkias alxchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Great doc in general by the way. I reviewed it entirely and feels very consistent, and easy to follow, considering it's a complex topic.

@shainaraskas
Copy link
Collaborator Author

@s-nel wonder if we should be creating better connections to the API operations for these procedures. what do you think?

@shainaraskas shainaraskas requested a review from s-nel September 11, 2025 20:41
@s-nel
Copy link

s-nel commented Sep 11, 2025

wonder if we should be creating better connections to the API operations for these procedures. what do you think?

What do you have in mind? I'm ++ to better connections from the UI approach the API approach

@shainaraskas
Copy link
Collaborator Author

@s-nel let me do that as a second PR so this is able to roll out in time for the release

@shainaraskas shainaraskas enabled auto-merge (squash) September 15, 2025 16:20
@shainaraskas shainaraskas merged commit 90a54b4 into main Sep 15, 2025
6 checks passed
@shainaraskas shainaraskas deleted the role-mapping-vfc branch September 15, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants