Update data-tiers.md #3003
Merged
Update data-tiers.md #3003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing description of "automatic data tier migration" did not explicitly call out the impact of setting "migrate": {
"enabled": false
} without specifying manual allocation rules. The setting alone can prevent data from moving to a data tier while "succeeding" through the ILM "complete" phase.
🔍 Preview links for changed docs |
kilfoyle
reviewed
Sep 18, 2025
kilfoyle
reviewed
Sep 18, 2025
kilfoyle
reviewed
Sep 18, 2025
kilfoyle
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
LGTM! 🚢
Just a couple of small suggestions. Thanks a lot @maggieghamry!
|
My pleasure @kilfoyle, thanks so much for the amazingly quick review and approval! 🎉 ❤️ |
|
Hi @maggieghamry! Just checking: Did you mean to close this PR unmerged? If not, we can reopen, apply the suggestions (if you like) and then merge. I just wouldn't want your proposed changes to be lost. |
|
So sorry @kilfoyle I sure didn't mean to close this 😅. Yes please, let me know if you're able to apply the suggestions and merge or if you would like me to. Thanks again! |
|
No problem @maggieghamry! I can take it from here (I'll commit the suggestions and merge the PR once the CI checks pass). :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing description of "automatic data tier migration" did not explicitly call out the impact of setting "migrate": {
"enabled": false
} without specifying manual allocation rules. The setting alone can prevent data from moving to a data tier while "succeeding" through the ILM "complete" phase.
I am also including an image that may be a useful addition contextually:
