Skip to content

Conversation

florent-leborgne
Copy link
Contributor

@rylnd @yctercero let me know if I got this right or suggest anything you'd like to see. The original issue mentions that kibana.alert.original_event.* behaves similarly but it's not described much in the docs from what I could find, so we may also clarify things for that one if you feel it's needed.

Once we're good with the content here, I'll create the corresponding PR for 8.19, as docs for this version are still in asciidoc in their previous location.

Closes: #2673

@florent-leborgne florent-leborgne requested a review from a team as a code owner September 18, 2025 09:31
Copy link

github-actions bot commented Sep 18, 2025

🔍 Preview links for changed docs

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rylnd
Copy link

rylnd commented Sep 18, 2025

@florent-leborgne thanks for this! A few comments:

  1. I agree that original_event.* should be similarly-worded, since the behavior is identical to original_data_stream.* (both are copied from the event's original event.* and data_stream.* fields.
  2. I think the data_stream.* section should be removed entirely. Those fields may or may not exist in the alert document's source, but they are never mapped and thus not particularly useful to the user (original_data_stream.* and their mappings are meant to supply that functionality).

| [`dns.*`](ecs://reference/ecs-dns.md) | ECS `dns.*` fields copied from the source document, if present, for custom query and indicator match rules. |
| [`error.*`](ecs://reference/ecs-error.md) | ECS `error.*` fields copied from the source document, if present, for custom query and indicator match rules. |
| [`event.*`](ecs://reference/ecs-event.md) | ECS `event.*` fields copied from the source document, if present, for custom query and indicator match rules.<br>**Note:** categorization fields above (`event.kind`, `event.category`, `event.type`, `event.outcome`) are listed separately above. |
| [`event.*`](ecs://reference/ecs-event.md) | ECS `event.*` fields copied from the source document, if present, for custom query and indicator match rules.<br>**Note:** categorization fields (`event.kind`, `event.category`, `event.type`, `event.outcome`) are listed separately. |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to the feedback but the double "above" sounded off.

@florent-leborgne
Copy link
Contributor Author

@rylnd Thanks for your comments! Let me know if this now looks closer to what you expected :)

Copy link

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@florent-leborgne florent-leborgne enabled auto-merge (squash) September 25, 2025 16:28
@florent-leborgne florent-leborgne merged commit f555d44 into elastic:main Sep 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Internal]: Update Security Alert schema to include new fields

3 participants