-
Notifications
You must be signed in to change notification settings - Fork 185
[E&A] Marks ELSER on EIS as GA #3014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
leemthompo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
florent-leborgne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seanhandley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @szabosteve ! One alteration suggested. We know throughput is better with EIS but latency is about the same, depending on load.
Co-authored-by: Sean Handley <[email protected]>
Co-authored-by: Max Jakob <[email protected]> Co-authored-by: florent-leborgne <[email protected]>
seanhandley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the rate limits reference cc @maxjakob
|
Good catch @seanhandley, we indeed need to remove the rate limits for now. |
Removed rate limits section from eis.md.
maxjakob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just made one small suggestion but already approving.
Co-authored-by: Max Jakob <[email protected]>
## Overview Related to elastic/search-team#10758 and elastic#3008 This PR: * amends the `applies_to` tags relevant to ELSER on EIS to mark the feature as GA * adds a Pricing section that links to the pricing page * removes limitations that are not relevant anymore ### Important note **Serverless:** After this PR is merged, the docs will state that ELSER on EIS is GA on Serverless. **Only merge once the feature is actually released as GA on Serverless.** **Stack:** If the PR is merged before the 9.2 release, the docs will show the GA status on the stack as Planned, without referencing a specific version. After the release, the badge will update dynamically to show the feature as GA in 9.2. --------- Co-authored-by: Sean Handley <[email protected]> Co-authored-by: Liam Thompson <[email protected]> Co-authored-by: Max Jakob <[email protected]> Co-authored-by: florent-leborgne <[email protected]>
## Overview Related to elastic/search-team#10758 and elastic#3008 This PR: * amends the `applies_to` tags relevant to ELSER on EIS to mark the feature as GA * adds a Pricing section that links to the pricing page * removes limitations that are not relevant anymore ### Important note **Serverless:** After this PR is merged, the docs will state that ELSER on EIS is GA on Serverless. **Only merge once the feature is actually released as GA on Serverless.** **Stack:** If the PR is merged before the 9.2 release, the docs will show the GA status on the stack as Planned, without referencing a specific version. After the release, the badge will update dynamically to show the feature as GA in 9.2. --------- Co-authored-by: Sean Handley <[email protected]> Co-authored-by: Liam Thompson <[email protected]> Co-authored-by: Max Jakob <[email protected]> Co-authored-by: florent-leborgne <[email protected]>
Overview
Related to https://github.com/elastic/search-team/issues/10758 and #3008
This PR:
applies_totags relevant to ELSER on EIS to mark the feature as GAImportant note
Serverless:
After this PR is merged, the docs will state that ELSER on EIS is GA on Serverless. Only merge once the feature is actually released as GA on Serverless.
Stack:
If the PR is merged before the 9.2 release, the docs will show the GA status on the stack as Planned, without referencing a specific version. After the release, the badge will update dynamically to show the feature as GA in 9.2.