Skip to content

Clarify ECE - document host maintenance with podman #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 25, 2025
Merged

Clarify ECE - document host maintenance with podman #3066

merged 15 commits into from
Sep 25, 2025

Conversation

kunisen
Copy link
Contributor

@kunisen kunisen commented Sep 22, 2025 •
edited
Loading

@kunisen kunisen requested a review from a team as a code owner September 22, 2025 03:06
@kunisen kunisen self-assigned this Sep 22, 2025
@kunisen kunisen added documentation Improvements or additions to documentation supportability ability enable self-service or support of product Team:Admin Issues owned by the Admin Docs Team labels Sep 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2025 •
edited
Loading

🔍 Preview links for changed docs

shainaraskas
shainaraskas reviewed Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this section. provided some small pieces of feedback (mostly formatting)

deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md Outdated
Comment on lines 77 to 79
:::{note}
This section only applies to Podman.
:::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be correct that the docker steps are only for docker installations?

suggest that the title makes tihs clear

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be correct that the docker steps are only for docker installations?

yep. If making that sort of note under podman, might it make sense to do the same under docker?

What if the page is also reorganized in this fashion to group by method/intent?

  • By disabling the container services (nondestructive):
    • For Docker-based installations: Disabling the Docker service
    • For Podman-based installations: Disabling the Podman-related services
  • By deleting the host (destructive)
  • By shutting down the host (less destructive)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ I like this nesting idea 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea! I updated - 56dde2d

kunisen and others added 8 commits September 24, 2025 12:01
@kunisen @shainaraskas
Update deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
570b980 
Co-authored-by: shainaraskas <[email protected]>
@kunisen @shainaraskas
Update deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
32ba704 
Co-authored-by: shainaraskas <[email protected]>
@kunisen @shainaraskas
Update deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
bd2388f 
Co-authored-by: shainaraskas <[email protected]>
@kunisen @shainaraskas
Update deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
06873fa 
Co-authored-by: shainaraskas <[email protected]>
@kunisen @shainaraskas
Update deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
baa7051 
Co-authored-by: shainaraskas <[email protected]>
@kunisen @shainaraskas
Update deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
dee79f1 
Co-authored-by: shainaraskas <[email protected]>
@kunisen @shainaraskas
Update deploy-manage/maintenance/ece/perform-ece-hosts-maintenance.md
cdd26f1 
Co-authored-by: shainaraskas <[email protected]>
@kunisen
Update perform-ece-hosts-maintenance.md
56dde2d 
tweaked the structure to make it nested and fixed the numbering
@kunisen
Copy link
Contributor Author

kunisen commented Sep 24, 2025

Thank you Shaina and Roberto!
I made some edits to reflect your inputs.
Please kindly check again.

shainaraskas
shainaraskas approved these changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really great. a couple last little style things and then good to go from my pov

@kunisen kunisen enabled auto-merge (squash) September 25, 2025 00:09
@kunisen kunisen disabled auto-merge September 25, 2025 00:09
rseldner
rseldner approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@rseldner rseldner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunisen
Copy link
Contributor Author

kunisen commented Sep 25, 2025

@pfcoperez @matt-elastic can one of you please kindly review this to prevent future SDH tickets?

Thanks Shaina and Roberto for the review!

matt-elastic
matt-elastic approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@matt-elastic matt-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunisen kunisen enabled auto-merge (squash) September 25, 2025 08:19
@kunisen
Copy link
Contributor Author

kunisen commented Sep 25, 2025

Thank you!

@kunisen kunisen merged commit ff372de into main Sep 25, 2025
6 of 7 checks passed
@kunisen kunisen deleted the kunisen-docpr-docsContentInternal-347 branch September 25, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rseldner rseldner rseldner approved these changes

@shainaraskas shainaraskas shainaraskas approved these changes

@matt-elastic matt-elastic matt-elastic approved these changes

@pfcoperez pfcoperez Awaiting requested review from pfcoperez

Assignees

@kunisen kunisen

Labels

documentation Improvements or additions to documentation supportability ability enable self-service or support of product Team:Admin Issues owned by the Admin Docs Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kunisen @rseldner @shainaraskas @matt-elastic