Skip to content

Conversation

ketkee-aryamane
Copy link
Contributor

@ketkee-aryamane ketkee-aryamane commented Sep 23, 2025

Linked to #2563
This PR removes the following under Explore and Analyze -> SQL and creates redirects to the corresponding reference content. Also updates all referred links to these files with the reference content links.

  • SQL Language
  • Functions and Operators
  • Reserved keywords
  • SQL Limitations

Copy link

github-actions bot commented Sep 23, 2025

@ketkee-aryamane ketkee-aryamane changed the title remove duplicate content for the section SQL langiage under Explore a… remove duplicate content for SQL under Explore a… Sep 23, 2025
@ketkee-aryamane ketkee-aryamane changed the title remove duplicate content for SQL under Explore a… remove duplicate content for certain SQL sections under Explore a… Sep 23, 2025
@ketkee-aryamane ketkee-aryamane changed the title remove duplicate content for certain SQL sections under Explore a… remove duplicate content for certain SQL sections under Explore and Analyze Sep 23, 2025
@ketkee-aryamane ketkee-aryamane marked this pull request as ready for review September 23, 2025 12:54
@ketkee-aryamane ketkee-aryamane requested review from a team as code owners September 23, 2025 12:54
Copy link
Contributor

@yetanothertw yetanothertw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved.

A suggestion/question: I've recently removed duplicated pages that existed in both the Deploy and manage and Reference sections in favour of the latter. I then added a crosslink to the toc in the Deploy and manage section because it made a lot of sense for the page to be listed in the toc. (It now redirects to the correct, deduplicated page in the Reference section.)
Not sure if this would apply to your use-case, but thought I'd mention it anyway.

@ketkee-aryamane
Copy link
Contributor Author

ketkee-aryamane commented Sep 23, 2025

Changes approved.

A suggestion/question: I've recently removed duplicated pages that existed in both the Deploy and manage and Reference sections in favour of the latter. I then added a crosslink to the toc in the Deploy and manage section because it made a lot of sense for the page to be listed in the toc. (It now redirects to the correct, deduplicated page in the Reference section.) Not sure if this would apply to your use-case, but thought I'd mention it anyway.

I see! But I think, as per the requirement listed in the issue, this content should only sit in the Reference docs. Good to clear with @florent-leborgne though. Thanks @yetanothertw

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ketkee-aryamane!

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (noted a couple of missing spaces) 🥳

@ketkee-aryamane ketkee-aryamane merged commit 788f45a into main Sep 23, 2025
6 checks passed
@ketkee-aryamane ketkee-aryamane deleted the remove-and-redirect-duplicated-SQL-doc-pages branch September 23, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants