Skip to content

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Feb 4, 2025

This reworks the "Transform and enrich data" section to supplement the content from Karen's ingest guide PR with content describing the child pages in this section, in accordance with the IA plan.

Please see: Docs preview
Rel: https://github.com/elastic/docs-projects/issues/366

Note to self: The "Elastic Agent processors" and all of the links to the Logstash docs need to be fixed after that content has been migrated. I understand that this part happens automatically when the reference content is migrated.

@kilfoyle kilfoyle changed the title Update 'Transform and enrich data' Expand 'Transform and enrich data' to match IA plan Feb 4, 2025
@kilfoyle kilfoyle changed the title Expand 'Transform and enrich data' to match IA plan [Manage data] Expand 'Transform and enrich data' to match IA plan Feb 5, 2025
@wajihaparvez
Copy link
Contributor

wajihaparvez commented Feb 5, 2025

Thanks for working on this @kilfoyle! Looks great to me 👏
I've just left some very minor suggestions for your consideration

wajihaparvez
wajihaparvez previously approved these changes Feb 5, 2025
---

# Ingest pipelines
# Elasticsearch ingest pipelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Elasticsearch ingest pipelines
# {{es}} ingest pipelines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karenzone! I agree with the change, however attributes are not currently working in titles, and some other places, so until that's resolved I'll leave the raw text (that's what I see other people doing in their PRs).

karenzone
karenzone previously approved these changes Feb 5, 2025
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @kilfoyle. And some good suggestions, @wajihaparvez. 🚀

@kilfoyle kilfoyle removed the request for review from colleenmcginnis February 5, 2025 20:12
@kilfoyle kilfoyle dismissed stale reviews from karenzone and wajihaparvez via 41857f2 February 5, 2025 21:12
@kilfoyle kilfoyle requested a review from wajihaparvez February 6, 2025 01:10
@kilfoyle kilfoyle merged commit c7baa09 into elastic:main Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants