Skip to content

Reduce number of warnings #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 4, 2025
Merged

Reduce number of warnings #320

merged 5 commits into from
Feb 4, 2025

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Feb 4, 2025 •
edited
Loading

What

  • Add external_hosts
  • Clean up code block languages where possible (some of these I'm not sure what to do with) progress over perfection

Result

  • Before: 3,035 warnings
  • After: 533 warnings

Code blocks changed

  • literal --> sh
  • term
  • esql
  • consol-result --> console-result
  • curl
  • log --> txt
  • painless
  • painless
  • regex --> txt
  • eql
  • mustache
  • output --> txt
  • esql
  • logstash --> various
  • curl
  • conf
  • systemd
  • synonyms --> markdown
  • grok
  • sqlcli
  • kibana

@bmorelli25 bmorelli25 changed the title add external_hosts Reduce number of warnings Feb 4, 2025
shainaraskas
shainaraskas approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bmorelli25 bmorelli25 merged commit 82a66be into main Feb 4, 2025
3 of 4 checks passed
@bmorelli25 bmorelli25 deleted the add-uris branch February 4, 2025 23:32
@bmorelli25 bmorelli25 mentioned this pull request Feb 13, 2025
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmorelli25 @shainaraskas