-
Notifications
You must be signed in to change notification settings - Fork 155
Update text and images for inline markdown #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mbondyra I'm still figuring out how to refresh these screenshots |
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alaudazzi these changes seem to reflect versions 9.2+ and serverless, while 9.0 and 9.1 users still have the previous experience for this panel. This needs to be reflected in these docs and 9.0/9.1 users must still find the old version of it.
I suggest using tabs (with the applies-switch component) to distinguish between the old and new experience for this panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These markup edits should help
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
Co-authored-by: florent-leborgne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏼 I think I'd make the screenshots maybe a bit bigger to encapsulate the whole area of markdown, without cutting the buttons, but it's a nit!
@florent can you have a final look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, we're nearly there. Just a couple of last comments to:
- order tabs from latest to oldest
- specify which tab corresponds to the serverless UI too
Co-authored-by: florent-leborgne <[email protected]>
Remove serverless tag
The full page applies to serverless, with no exception for the refreshed UI. |
Co-authored-by: florent-leborgne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR updates the page https://www.elastic.co/docs/explore-analyze/visualize/text-panels to reflect the new Inline markdown editor.
Relates to elastic/kibana#229191
Closes #3076