-
Notifications
You must be signed in to change notification settings - Fork 152
Create new Contribute to docs
section, move existing content
#3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT — thanks!
Only comment: how about renaming the index "Contribute to the docs" instead of "Contribute to docs"?
contribute-docs/toc.yml
Outdated
@@ -0,0 +1,11 @@ | |||
toc: | |||
- file: index.md | |||
- file: api-docs/index.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- file: api-docs/index.md
This seems like a duplication of what's in the api-docs/toc.yml
file. Is the duplication necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I actually had a failing all-repo build when I didn't do this duplication
but maybe I could restructure somewhere else?
contribute-docs/toc.yml
Outdated
- file: api-docs/index.md | ||
children: | ||
- file: api-docs/overview.md | ||
- file: api-docs/checklist.md | ||
- file: api-docs/guidelines.md | ||
- file: api-docs/organize-annotate.md | ||
- file: api-docs/quickstart.md | ||
- file: api-docs/workflows.md | ||
- file: api-docs/help.md No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- file: api-docs/index.md | |
children: | |
- file: api-docs/overview.md | |
- file: api-docs/checklist.md | |
- file: api-docs/guidelines.md | |
- file: api-docs/organize-annotate.md | |
- file: api-docs/quickstart.md | |
- file: api-docs/workflows.md | |
- file: api-docs/help.md | |
- folder: api-docs | |
children: | |
- file: index.md | |
- file: overview.md | |
- file: checklist.md | |
- file: guidelines.md | |
- file: organize-annotate.md | |
- file: quickstart.md | |
- file: workflows.md | |
- file: help.md |
Remove api-docs/toc.yml
if you do not intend to place the api-docs/toc.yml
some place different then under contribute-docs/api-docs
as defined here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ha! I knew something was off with that duplication
thanks @Mpdreamz
Contributes to https://github.com/elastic/docs-content-internal/issues/334
I validated with a full docs-builder build locally
Summary
• Created top-level
contribute-docs/
section - New main section for public docs contribution guidelines• Moved API docs guidelines from
extend/contribute/api-docs/
tocontribute-docs/api-docs/
• Updated
docset.yml
- Addedtoc: contribute-docs
to main navigation• Updated
extend/toc.yml
- Removed references to moved files, simplified structure• Added redirects - All old URLs redirect to new locations
• Created new TOC files -
contribute-docs/toc.yml
andcontribute-docs/api-docs/toc.yml
Related PR in
docs-builder
elastic/docs-builder#1969