Skip to content

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Sep 30, 2025

Contributes to https://github.com/elastic/docs-content-internal/issues/334

I validated with a full docs-builder build locally

Summary

Created top-level contribute-docs/ section - New main section for public docs contribution guidelines
Moved API docs guidelines from extend/contribute/api-docs/ to contribute-docs/api-docs/
Updated docset.yml - Added toc: contribute-docs to main navigation
Updated extend/toc.yml - Removed references to moved files, simplified structure
Added redirects - All old URLs redirect to new locations
Created new TOC files - contribute-docs/toc.yml and contribute-docs/api-docs/toc.yml

Related PR in docs-builder

elastic/docs-builder#1969

Copy link
Contributor

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT — thanks!

Only comment: how about renaming the index "Contribute to the docs" instead of "Contribute to docs"?

@@ -0,0 +1,11 @@
toc:
- file: index.md
- file: api-docs/index.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • file: api-docs/index.md

This seems like a duplication of what's in the api-docs/toc.yml file. Is the duplication necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I actually had a failing all-repo build when I didn't do this duplication

but maybe I could restructure somewhere else?

@leemthompo leemthompo requested review from a team and reakaleek October 2, 2025 10:49
Comment on lines 3 to 11
- file: api-docs/index.md
children:
- file: api-docs/overview.md
- file: api-docs/checklist.md
- file: api-docs/guidelines.md
- file: api-docs/organize-annotate.md
- file: api-docs/quickstart.md
- file: api-docs/workflows.md
- file: api-docs/help.md No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- file: api-docs/index.md
children:
- file: api-docs/overview.md
- file: api-docs/checklist.md
- file: api-docs/guidelines.md
- file: api-docs/organize-annotate.md
- file: api-docs/quickstart.md
- file: api-docs/workflows.md
- file: api-docs/help.md
- folder: api-docs
children:
- file: index.md
- file: overview.md
- file: checklist.md
- file: guidelines.md
- file: organize-annotate.md
- file: quickstart.md
- file: workflows.md
- file: help.md

Remove api-docs/toc.yml if you do not intend to place the api-docs/toc.yml some place different then under contribute-docs/api-docs as defined here:

https://github.com/elastic/docs-builder/pull/1969/files#diff-d014d789ee176611c685a20fa11c33373fb72cae6711b431a0ab961881a80b94R25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ha! I knew something was off with that duplication

thanks @Mpdreamz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Initiative 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants