-
Notifications
You must be signed in to change notification settings - Fork 155
Docs update for ES|QL editor prettify option #3236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I'd consider removing the {note}
because only the hover text has changed and the admonition kinda feels disproportionate to the magnitude of the change. Especially now that you've added the icon in the docs 💅.
In isolation it seems fine, but if we consider small tweaks like this in the UI having an outsized impact on the docs over multiple minors, could get unreadable fast.
@leemthompo I was already hesitating because of that specific reason (the icon name is only visible in the tooltip) so I need convincing no more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
In serverless and from 9.2, the "Add line breaks on pipes" becomes "Prettify query". This change highlights this and also updates the example gif with something more illustrative (more than 2 lines)
Closes: #3095