-
Notifications
You must be signed in to change notification settings - Fork 152
Add documentation for managing ECK file-based password length. #3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: eck-3.2.0
Are you sure you want to change the base?
Add documentation for managing ECK file-based password length. #3339
Conversation
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
🔍 Preview links for changed docs |
Signed-off-by: Michael Montgomery <[email protected]>
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Montgomery <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have suggested to place the applies_to right after the heading, and not after the initial note.
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Show resolved
Hide resolved
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Montgomery <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good. I think we want to consider relocating this chunk of info though because it's specific to the file realm. would you consider making it an H4 under the File realm
heading?
:::{note} | ||
Changing these values does not update existing passwords. To rotate current credentials, refer to the [rotating credentials documentation](#k8s-rotate-credentials) | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably ok outside of a note
:::{note} | |
Changing these values does not update existing passwords. To rotate current credentials, refer to the [rotating credentials documentation](#k8s-rotate-credentials) | |
::: | |
Changing these values does not update existing passwords. To rotate current credentials, refer to the [rotating credentials documentation](#k8s-rotate-credentials) |
``` | ||
|
||
:::{note} | ||
The ability to control the length of passwords for [file-based credentials](/deploy-manage/users-roles/cluster-or-deployment-auth/file-based.md) generated by {{eck}} requires an Enterprise license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want this to not be two notes in a trenchcoat

The ability to control the length of passwords for [file-based credentials](/deploy-manage/users-roles/cluster-or-deployment-auth/file-based.md) generated by {{eck}} requires an Enterprise license. | |
The ability to control the length of passwords for [file-based credentials](/deploy-manage/users-roles/cluster-or-deployment-auth/file-based.md) generated by {{eck}} requires an Enterprise license. | |
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(+ approving to unblock)
(oops, guess this tab was old and edu already got you)
The following elastic/cloud-on-k8s#8817 is planned to be released with the ECK 3.2/Stack 9.2 release.
(replaces #3322 as it was based of the wrong branch)