-
Notifications
You must be signed in to change notification settings - Fork 156
[Do not merge] [E&A] Add applies frontmatter to most explore and analyze files #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] [E&A] Add applies frontmatter to most explore and analyze files #336
Conversation
I question whether this is needed. I'm hoping we end up with some sort of banner saying "these docs are 9.x+, ECE 4.x+" We might want to add a 9.x indicator on features we know are new in 9.x but I don't think it needs to be everywhere if we get that banner. We might also consider having an "about these docs" page that makes is clear what the badges mean and what the "default" or "empty" state means. |
@shainaraskas good points. That could be way better than what I proposed there, especially on the long term when 7.x and 8.x are ancient history (though it could take a bit of time). As long as we make it obvious to any reader that what they're reading doesn't apply to pre-9.0, I'm good with it |
The `kibana_admin` role or equivalent is required to manage **Spaces**. | ||
|
||
::::{note} | ||
In a serverless project, you must have an admin role on that project to manage its **Spaces**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a serverless project, you must have an admin role on that project to manage its Spaces.
Do we need to have this in an admonition? This seems unnecessarily eye-catching to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Lisa. wonder if we could do something like this:
* Serverless projects: **Admin** or equivalent
* <Some word that means all but serverless>: `kibana_admin` or equivalent
You can have up to 1,000 spaces by default. The maximum number of spaces can be configured by the `xpack.spaces.maxSpaces` setting (refer to [Spaces settings in {{kib}}](https://www.elastic.co/guide/en/kibana/current/spaces-settings-kb.html)). | ||
|
||
::::{note} | ||
In a serverless project, the number of spaces is limited to 100. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a serverless project, the number of spaces is limited to 100.
This is another one that I don't think merits an admonition. But if we do go down this path as far as a best practice we'll want to give advice on what warrants admonitions in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The maximum number of spaces that you can have differs by deployment type:
* Serverless: Maximum of 100 spaces
* <Some word that means all but serverless>: Controlled by the [`xpack.spaces.maxSpaces`](https://www.elastic.co/guide/en/kibana/current/spaces-settings-kb.html) setting. Default is 1000.
Thanks for drafting these examples! My preference is for |
…ct-tags-explore-analyze
I like the tabs for when there's anything more than a handful of differences, it feels a lot cleaner and easier to parse as a reader. My only concern would be that hand-building tabs is not scaleable, so I'd want a compact syntax in the source (yaml if possible), which the build system transforms into the appropriate presentation. Whatever approach we decide on, I'd push very strongly for separating form and content in this way, so that we can make changes to how stuff is presented going forward by fixing it in the CSS/build system, rather than having to edit the source pages. That way if we decide tabs don't scale past a certain point, we don't have a lot of manual debt to repay down the line. Two other opinions:
|
I think this could work well when there are less than a handful targeted differences on the page, but it won't scale well over time in such instructional content. Already for this example, I find it hard to read, especially for a serverless user, with too much content that the reader has to process while it doesn't even apply to them. |
::::{note} | ||
In serverless projects, customizing access to a space is available for the following project types only: [](/solutions/search.md) [](/solutions/security/elastic-security-serverless.md) | ||
:::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider pulling this out of a note as well
Serverless project types: [](/solutions/search.md) [](/solutions/security/elastic-security-serverless.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I think we all agree that using notes for version/deployment type differences isn't a great way to show it
to everyone in this thread looking at the versioning strategy: I've moved the examples to a new, smaller PR so they can be previewed using the auto build |
This was for testing, closing |
[This PR will evolve - it's not a proposal]
For now this is a place for discussion and ideas on options we have to call out content applicability at:
Most likely dimensions to call out are:
Observations:
applies
frontmatter needs to provide a way to indicate this instead of a single version. For instance,stack: ga "From 9.0.0"