-
Notifications
You must be signed in to change notification settings - Fork 181
Add OTLP docs #3360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLP docs #3360
Conversation
manage-data/data-store/data-streams/time-series-data-stream-tsds.md
Outdated
Show resolved
Hide resolved
🔍 Preview links for changed docs |
theletterf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, Felix! Made some edits and left a couple of questions.
theletterf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can merge when you're ready.
Co-authored-by: Kostas Krikellas <[email protected]>
|
I had a chat with Kostas and I've reworked the information architecture a bit. We want to promote OTEL-based ingestion as an easier way to get data into TSDB. At the same time, we want to de-emphasize the ES OTLP Endpoint as users shouldn't directly send data to it. The data should go to an OTel collector or the managed OTLP Endpoint on serverless. These can then use the ES OTLP Endpoint as and implementation detail. |
These commits are in my branch -- so no, not ready to merge yet 🙃 |
|
@marciw Ah! I didn't notice that it's not targeting |
vigneshshanmugam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| If you're looking to ingest OpenTelemetry metrics, | ||
| follow the [OpenTelemetry quickstarts](/solutions/observability/get-started/opentelemetry/quickstart/index.md). | ||
| This allows you to start sending data into a TSDS without having to worry about manually setting up data streams or configuring mappings. | ||
| :::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One the fence about having it here as well.. will defer to @marciw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, linking from the TSDS quickstart to the OTel quickstart kinda makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the addition, except it kind of takes over the top of the page. But I can maybe work on making it a bit smaller -- OK as is for now
| ::::{note} | ||
| If you're looking to ingest OpenTelemetry metrics, | ||
| follow the [OpenTelemetry quickstarts](/solutions/observability/get-started/opentelemetry/quickstart/index.md). | ||
| This allows you to start sending data into a TSDS without having to worry about manually setting up data streams or configuring mappings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe: "For more details on how this is handled in Elasticsearch, check out [OTLP/HTTP endpoint
]{...}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this is merged into my branch, I'll make sure everything matches Elastic docs style (this note can be shorter and more direct)
marciw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will make a few more edits in my in-progress PR after this is merged 👍
| If you're looking to ingest OpenTelemetry metrics, | ||
| follow the [OpenTelemetry quickstarts](/solutions/observability/get-started/opentelemetry/quickstart/index.md). | ||
| This allows you to start sending data into a TSDS without having to worry about manually setting up data streams or configuring mappings. | ||
| :::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the addition, except it kind of takes over the top of the page. But I can maybe work on making it a bit smaller -- OK as is for now
| ::::{note} | ||
| If you're looking to ingest OpenTelemetry metrics, | ||
| follow the [OpenTelemetry quickstarts](/solutions/observability/get-started/opentelemetry/quickstart/index.md). | ||
| This allows you to start sending data into a TSDS without having to worry about manually setting up data streams or configuring mappings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this is merged into my branch, I'll make sure everything matches Elastic docs style (this note can be shorter and more direct)
|
hmm, let's hold off on merging this until I can clarify how/whether |
kilfoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
Very nice @felixbarny!
@felixbarny ah sigh, didn't want you to merge this yet 😢 can you check with me first, if you're planning to work with my branch further? thank you! |
|
Ah, sorry, I thought the additional approval of @kilfoyle, who is part of I'm not planning to make further changes to your branch. Feel free to revert if it's causing issues and we can re-do it later. |
Adds docs for the new OTLP endpoint added via elastic/elasticsearch#133057
Closes #3363